Mesa (master): amd/addrlib: mark microBlockDim as MAYBE_UNUSED in Addr::V2::Gfx9Lib::HwlComputeBlock256Equation
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Aug 22 18:33:46 UTC 2018
Module: Mesa
Branch: master
Commit: 556f89a7158bfaa5a2332ac84c7be9b113a80f13
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=556f89a7158bfaa5a2332ac84c7be9b113a80f13
Author: Kai Wasserbäch <kai at dev.carbon-project.org>
Date: Sat Aug 18 11:45:30 2018 +0200
amd/addrlib: mark microBlockDim as MAYBE_UNUSED in Addr::V2::Gfx9Lib::HwlComputeBlock256Equation
Only used, when asserts are enabled.
Fixes an unused-but-set-variable warning with GCC 8:
../../../src/amd/addrlib/gfx9/gfx9addrlib.cpp: In member function 'virtual ADDR_E_RETURNCODE Addr::V2::Gfx9Lib::HwlComputeBlock256Equation(AddrResourceType, AddrSwizzleMode, unsigned int, ADDR_EQUATION*) const':
../../../src/amd/addrlib/gfx9/gfx9addrlib.cpp:2473:15: warning: variable 'microBlockDim' set but not used [-Wunused-but-set-variable]
Dim2d microBlockDim = Block256_2d[elementBytesLog2];
^~~~~~~~~~~~~
Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/amd/addrlib/gfx9/gfx9addrlib.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/amd/addrlib/gfx9/gfx9addrlib.cpp b/src/amd/addrlib/gfx9/gfx9addrlib.cpp
index ef86c3bc7b..853a041158 100644
--- a/src/amd/addrlib/gfx9/gfx9addrlib.cpp
+++ b/src/amd/addrlib/gfx9/gfx9addrlib.cpp
@@ -37,6 +37,8 @@
#include "amdgpu_asic_addr.h"
+#include "util/macros.h"
+
////////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -2470,7 +2472,7 @@ ADDR_E_RETURNCODE Gfx9Lib::HwlComputeBlock256Equation(
// Post validation
if (ret == ADDR_OK)
{
- Dim2d microBlockDim = Block256_2d[elementBytesLog2];
+ MAYBE_UNUSED Dim2d microBlockDim = Block256_2d[elementBytesLog2];
ADDR_ASSERT((2u << GetMaxValidChannelIndex(pEquation->addr, 8, 0)) ==
(microBlockDim.w * (1 << elementBytesLog2)));
ADDR_ASSERT((2u << GetMaxValidChannelIndex(pEquation->addr, 8, 1)) == microBlockDim.h);
More information about the mesa-commit
mailing list