Mesa (staging/18.2): 22 new commits

Mon Dec 3 16:50:47 UTC 2018

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=644f1941eccab4ef20810f7562771d59d4871932
Author: Gurchetan Singh <gurchetansingh at chromium.org>
Date:   Mon Nov 26 09:54:05 2018 -0800

    virgl: don't mark buffers as unclean after a write

    We can mark the buffer unclean if it's ever bound as a TBO,
    SSBO, ABO, or image.

    This improves

    dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw

    from 9.58 MB/s to 451.17 MB/s.

    v2: Track buffer cleanliness as a function of bindings (Ilia).
    v3: virgl_modify_clean --> virgl_dirty_res (Erik)

    Tested-By: Gert Wollny <gert.wollny at collabora.com>
    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    (cherry picked from commit 89b4798c0619a2ba99046d5ad36f0e6851625f7a)
    [Juan A. Suarez: resolve trivial conflicts]
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

    Conflicts:
    	src/gallium/drivers/virgl/virgl_encode.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d058dc4aa3d1a15b4164c221ec3bd4dac72a5946
Author: Gurchetan Singh <gurchetansingh at chromium.org>
Date:   Mon Nov 26 09:54:04 2018 -0800

    virgl: avoid large inline transfers

    We flush everytime the command buffer (16 kB) is full, which is
    quite costly.

    This improves

    dEQP-GLES3.performance.buffer.data_upload.function_call.buffer_data.new_buffer.usage_stream_draw

    from 111.16 MB/s to 1930.36 MB/s.

    In addition, I made the benchmark produce buffers from 0 --> VIRGL_MAX_CMDBUF_DWORDS * 4,
    and tried ((VIRGL_MAX_CMDBUF_DWORDS * 4) / 2), ((VIRGL_MAX_CMDBUF_DWORDS * 4) / 4), etc.

    I didn't notice any clear differences, so let's just go with the most obvious
    heuristic.

    Tested-By: Gert Wollny <gert.wollny at collabora.com>
    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    (cherry picked from commit d18492c64f0abb4eb638d2b213b4b1ff3d775965)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf482d48f433bfb6cf9f26fc154c967d20971eeb
Author: Gurchetan Singh <gurchetansingh at chromium.org>
Date:   Mon Nov 26 09:54:03 2018 -0800

    virgl: quadruple command buffer size

    Tested running WebGL aquarium on Nvidia host (10,000 fishes)

    This moves us from 7 fps to 9 fps.  After quadrupling, performance
    gains diminish.

    v2: Remove change ID (Erik)

    Tested-By: Gert Wollny <gert.wollny at collabora.com>
    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    (cherry picked from commit c0773315af76cd735152c322cb7f710b4b053148)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c52d56be8c468459862c70bd2ed066efffdc26f
Author: Karol Herbst <kherbst at redhat.com>
Date:   Sat Nov 24 20:00:00 2018 +0100

    nv50,nvc0: Fix gallium nine regression regarding sampler bindings

    The new approach is that samplers don't get unbound even if they won't be used
    in a draw and we should just leave them be as well.

    Fixes a regression in multiple windows games using gallium nine and nouveau.

    v2: adjust num_samplers to keep track of the highest sampler bound
    v3: rework how to set the new value of num_samplers

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106577
    Fixes: 4d6fab245eec3880e2a59424a579851f44857ce8
           "cso: don't track the number of sampler states bound"
    Signed-off-by: Karol Herbst <kherbst at redhat.com>
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
    (cherry picked from commit fc0139d28339f58bcbb4946fea7608ecdaff93e7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=828e18b58f9f938f89066a18000cbdc28d15404a
Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Nov 5 10:50:41 2018 -0800

    st/xvmc: Add X11 include path.

    This patch fixes this build error.

      CC       tests/xvmc_bench.o
    In file included from tests/xvmc_bench.c:35:
    tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found
             ^~~~~~~~~~~~

    Signed-off-by: Vinson Lee <vlee at freedesktop.org>
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 4f74580d3038eca1b751a71e0c098ea9eb9cdb05)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c26f7b34410c0efd4949cf160cffbb6b8f7d63af
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Fri Nov 30 12:33:38 2018 +0100

    cherry-ignore: freedreno: Fix autotools build.

    fixes: This commit fixes commits b4476138d5ad and aa0fed10d357 which did
    not land in branch.

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3fb3fd10e0d65dba25db017c1bf23b2d1d14ee9
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Tue Nov 20 17:35:27 2018 +0000

    vulkan/wsi: fix s/,/;/ typo

    Fixes: 59e58c348e6af16a5f2dd "vulkan/wsi: Only wait on semaphores on the first swapchain"
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit e0f1f74eda6e1bdb3bcee075f6cc5082d4137069)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a45e5538fd14a3ab12fb42a0f5a5e826f7d3801
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Tue Nov 27 13:34:37 2018 +0000

    wsi/display: fix mem leak when freeing swapchains

    Fixes: da997ebec92942193955 "vulkan: Add KHR_display extension using DRM [v10]"
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Keith Packard <keithp at keithp.com>
    (cherry picked from commit 9575cd289325ddbfa96291d7886cfc32a0487e79)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbe7b48d71f2aa4a0c2884a36226bb7e3abaca79
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sat Nov 24 23:21:05 2018 +0100

    radv: Clamp gfx9 image view extents to the allocated image extents.

    Mirrors AMDVLK. Looks like if we go over the alignment of height
    we actually start to change the addressing. Seems like the extra
    miplevels actually work with this.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108245
    Fixes: f6cc15dccd5 "radv/gfx9: fix block compression texture views. (v2)"
    Reviewed-by: Dave Airlie <airlied at redhat.com>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit 08ea6b9d9bb047603c249468dfe00d7bb9603d5e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d5e3935ecbd9bd7ce24cca422ba3a94a9498b2c8
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Fri Nov 23 17:08:28 2018 +0000

    anv: correctly use vulkan 1.0 by default

    Per chapter 3.2 "Instances":
    > Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing
    > an apiVersion of 0 is equivalent to providing an apiVersion of
    > VK_MAKE_VERSION(1,0,0).

    Reported-by: Niklas Haas <git at haasn.xyz>
    Fixes: 8c048af5890d43578ca4 "anv: Copy the appliation info into the instance"
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    (cherry picked from commit 56d126f8fd210dbd2c946bfbc2e3c81b04d27d09)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3feae1e53f165b03baff5a7d13276c661a275cee
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date:   Thu Nov 29 13:02:03 2018 +0000

    anv: flush pipeline before query result copies

    Pipeline state pending bits should be taken into account when copying
    results.

    In the particular bug below, the results of the
    vkCmdCopyQueryPoolResults() command was being overwritten by the
    preceding vkCmdCopyBuffer() with a same destination buffer. This is
    because we copy the buffers using the 3D pipeline whereas we copy the
    query results using the command streamer. Those pieces of HW work in
    parallel and the results are somewhat undefined.

    v2: Unconditionally flush the pipeline before copying the results
        (Jason)

    v3: Wrap & expressions (Jason)

    Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Suggested-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108894
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 37f9788e9a8e443772b5ad6f339567e6ae6a8320)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5df893b13c37b1f40021843cf746a77235b55ed4
Author: Thomas Hellstrom <thellstrom at vmware.com>
Date:   Mon Nov 26 19:05:47 2018 +0100

    winsys/svga: Fix a memory leak

    The ioctl.cap_3d member was never freed.

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
    Reviewed-by: Sinclair Yeh <syeh at vmware.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 058f85d41cbe3534b1a06d321fab9afb8fbadfc0)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=30cebff87d107cb5bf42b0364ae27c7e0381e013
Author: Thomas Hellstrom <thellstrom at vmware.com>
Date:   Mon Nov 26 19:02:08 2018 +0100

    st/xa: Fix a memory leak

    Free the context after destruction.

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
    Reviewed-by: Sinclair Yeh <syeh at vmware.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 7fce3ca3759e2e156e2e3bf1bcc4ee378dc7fa2d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=90ed59748389c695a08ffeec34777088ee8a24e0
Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Oct 11 13:44:02 2018 +1000

    r600: make suballocator 256-bytes align

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108311
    Cc: <mesa-stable at lists.freedesktop.org>
    (cherry picked from commit 2ddd44d941648d49dc0d917e03a579baec3590d9)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=555a629b357669b492653dfba6cfd07e2c67cbf0
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date:   Wed Nov 28 18:30:36 2018 +0100

    egl/wayland: rather obvious build fix

    Fixes: ce74a7bb8de7 ("egl/wayland: plug memory leak in drm_handle_device()")
    Fixes: c59d3aa4b9bc ("egl/wayland: bail out when drmGetMagic fails")
    (cherry picked from commit c02390f8fcd367c7350db568feabb2f062efca14)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf14779a8372e9eb173e98cec1b486a3ec588032
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Tue Nov 27 11:36:01 2018 +0000

    egl/wayland: plug memory leak in drm_handle_device()

    As we fail to open the node, we leak the node/device name.

    v2: Log and then free() (Eric)

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
    (cherry picked from commit ce74a7bb8de7f5b921d53384582de3324290cd60)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=79c4bf0dacdc61527fe423084c3d8717744028f9
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Nov 23 12:55:38 2018 +0000

    egl/wayland: bail out when drmGetMagic fails

    Currently as the function fails, we pass uninitialized data to the
    authentication function. Stop doing that and print an warning when
    the function fails.

    v2: Plug memory leak in error path (Eric)

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com> (v1)
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
    (cherry picked from commit c59d3aa4b9bc58994e199052171a8119aaa8195c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c14ed4944532ad8cc24f798bcdbac67aee4bc3a6
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Mon Nov 26 03:28:05 2018 +0100

    radv: Align large buffers to the fragment size.

    Improves performance in Talos by about 15% (and significant improvements
    in RotR and possibly other but did not bench with final patch) on
    kernel 4.19 and earlier.

    On 4.20+ a similar effect comes from

    433ca054949a "drm/amdgpu: try allocating VRAM as power of two"

    v2: Do not impact the alignment of the physical memory.

    Reviewed-by: Dave Airlie <airlied at redhat.com>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    CC: <mesa-stable at lists.freedesktop.org>
    (cherry picked from commit 6569644bb6e1f58fd739d83bd4dc42e6af6b6097)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfd1f8b92cae9dde3e5bed42109b5142f50a2ee5
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Nov 28 19:14:21 2018 +0100

    docs: add sha256 checksums for 18.2.6

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e741344d79e3ae67b1ad645e7d56fe6c0fb2ae2
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Nov 28 18:39:26 2018 +0100

    docs: add release notes for 18.2.6

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cbbe3b0acdd47e8a9b55fecf56b349cb43cbfafb
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Nov 28 18:38:40 2018 +0100

    Update version to 18.2.6

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=474690cfa464d0c807f20dfed260a452b8fbecbc
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Nov 28 18:36:33 2018 +0100

    docs: add sha256 checksums for 18.2.5

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>