Mesa (master): loader: free error state, when checking the drawable type

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: a539316485ddda074ca1b71aebf4a29b65af87c3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a539316485ddda074ca1b71aebf4a29b65af87c3

Author: Kirill Burtsev <kirill.burtsev at qt.io>
Date:   Wed Dec  5 15:54:27 2018 +0000

loader: free error state, when checking the drawable type

Currently we distinguish if the drawable is a window or pixmap by
checking xcb_present_select_input throws an error or not.

Yet, we don't always free the error state returned by xcb.

Cc: Kirill Burtsev <kirill.burtsev at qt.io>
Cc: Boyan Ding <boyan.j.ding at gmail.com>
Fixes: 6bd9ba7d074 ("loader: Add dri3 helper")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
[Emil: add commit message, fixes tag]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

---

 src/loader/loader_dri3_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index 1981b5f051..7cd6b1e8ab 100644
--- a/src/loader/loader_dri3_helper.c
+++ b/src/loader/loader_dri3_helper.c
@@ -1509,6 +1509,7 @@ dri3_update_drawable(struct loader_dri3_drawable *draw)
             mtx_unlock(&draw->mtx);
             return false;
          }
+         free(error);
          draw->is_pixmap = true;
          xcb_unregister_for_special_event(draw->conn, draw->special_event);
          draw->special_event = NULL;