Mesa (master): vc4: Reuse nir_format_convert.h in our blend lowering.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Dec 17 17:56:49 UTC 2018
Module: Mesa
Branch: master
Commit: 376054fff34a5b2d2c123bdc5d27af6196ef0f51
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=376054fff34a5b2d2c123bdc5d27af6196ef0f51
Author: Eric Anholt <eric at anholt.net>
Date: Sat Dec 15 19:31:22 2018 -0800
vc4: Reuse nir_format_convert.h in our blend lowering.
These helpers came along after and have effectively the same
implementation.
---
src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 36 +++------------------------
1 file changed, 3 insertions(+), 33 deletions(-)
diff --git a/src/gallium/drivers/vc4/vc4_nir_lower_blend.c b/src/gallium/drivers/vc4/vc4_nir_lower_blend.c
index 60eccb4fc0..67ae05d4f6 100644
--- a/src/gallium/drivers/vc4/vc4_nir_lower_blend.c
+++ b/src/gallium/drivers/vc4/vc4_nir_lower_blend.c
@@ -42,6 +42,7 @@
#include "util/u_format.h"
#include "vc4_qir.h"
#include "compiler/nir/nir_builder.h"
+#include "compiler/nir/nir_format_convert.h"
#include "vc4_context.h"
static bool
@@ -67,37 +68,6 @@ vc4_nir_get_dst_color(nir_builder *b, int sample)
return &load->dest.ssa;
}
-static nir_ssa_def *
-vc4_nir_srgb_decode(nir_builder *b, nir_ssa_def *srgb)
-{
- nir_ssa_def *is_low = nir_flt(b, srgb, nir_imm_float(b, 0.04045));
- nir_ssa_def *low = nir_fmul(b, srgb, nir_imm_float(b, 1.0 / 12.92));
- nir_ssa_def *high = nir_fpow(b,
- nir_fmul(b,
- nir_fadd(b, srgb,
- nir_imm_float(b, 0.055)),
- nir_imm_float(b, 1.0 / 1.055)),
- nir_imm_float(b, 2.4));
-
- return nir_bcsel(b, is_low, low, high);
-}
-
-static nir_ssa_def *
-vc4_nir_srgb_encode(nir_builder *b, nir_ssa_def *linear)
-{
- nir_ssa_def *is_low = nir_flt(b, linear, nir_imm_float(b, 0.0031308));
- nir_ssa_def *low = nir_fmul(b, linear, nir_imm_float(b, 12.92));
- nir_ssa_def *high = nir_fsub(b,
- nir_fmul(b,
- nir_imm_float(b, 1.055),
- nir_fpow(b,
- linear,
- nir_imm_float(b, 0.41666))),
- nir_imm_float(b, 0.055));
-
- return nir_bcsel(b, is_low, low, high);
-}
-
static nir_ssa_def *
vc4_blend_channel_f(nir_builder *b,
nir_ssa_def **src,
@@ -501,14 +471,14 @@ vc4_nir_blend_pipeline(struct vc4_compile *c, nir_builder *b, nir_ssa_def *src,
/* Turn dst color to linear. */
for (int i = 0; i < 3; i++)
- dst_color[i] = vc4_nir_srgb_decode(b, dst_color[i]);
+ dst_color[i] = nir_format_srgb_to_linear(b, dst_color[i]);
nir_ssa_def *blend_color[4];
vc4_do_blending_f(c, b, blend_color, src_color, dst_color);
/* sRGB encode the output color */
for (int i = 0; i < 3; i++)
- blend_color[i] = vc4_nir_srgb_encode(b, blend_color[i]);
+ blend_color[i] = nir_format_linear_to_srgb(b, blend_color[i]);
packed_color = vc4_nir_swizzle_and_pack(c, b, blend_color);
} else {
More information about the mesa-commit
mailing list