Mesa (master): radv: fix subpass image transitions with multiviews
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Dec 20 12:35:09 UTC 2018
Module: Mesa
Branch: master
Commit: 5c7935f8fc7dc0fd6e2495da36f66c51f966e489
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5c7935f8fc7dc0fd6e2495da36f66c51f966e489
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Dec 20 12:03:16 2018 +0100
radv: fix subpass image transitions with multiviews
The driver needs to decompress all image layers if a fast
depth/color clear has been performed.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
---
src/amd/vulkan/radv_cmd_buffer.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index aebf93b447..c61310f3fc 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2315,6 +2315,17 @@ static void radv_handle_subpass_image_transition(struct radv_cmd_buffer *cmd_buf
range.baseArrayLayer = view->base_layer;
range.layerCount = cmd_buffer->state.framebuffer->layers;
+ if (cmd_buffer->state.subpass && cmd_buffer->state.subpass->view_mask) {
+ /* If the current subpass uses multiview, the driver might have
+ * performed a fast color/depth clear to the whole image
+ * (including all layers). To make sure the driver will
+ * decompress the image correctly (if needed), we have to
+ * account for the "real" number of layers. If the view mask is
+ * sparse, this will decompress more layers than needed.
+ */
+ range.layerCount = util_last_bit(cmd_buffer->state.subpass->view_mask);
+ }
+
radv_handle_image_transition(cmd_buffer,
view->image,
cmd_buffer->state.attachments[idx].current_layout,
More information about the mesa-commit
mailing list