Mesa (staging/18.2): 27 new commits

Thu Dec 20 16:57:07 UTC 2018

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f295c18f14fed59a47f79dd27d07c88948afb72
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date:   Fri Dec 14 22:19:24 2018 -0800

    nir: properly clear the entry sources in copy_prop_vars

    When updating a copy entry source value from a "non-SSA" (the data
    come from a copy instruction) to a "SSA" (the data or parts of it come
    from SSA values), it was possible to hold invalid data in ssa[0]
    depending on the writemask.  Because the union, ssa[0] could contain a
    pointer to a nir_deref_instr left-over from previous non-SSA usage.

    Change code to clean up the array before use to avoid invalid data
    around.

    Fixes: 62332d139c8 "nir: Add a local variable-based copy propagation pass"
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 0ddc911f4d83a3c698ea02696e1b8706b2cce381)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8df9d5f43b105479a452a82217fc1d66ea16c69a
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Thu Dec 20 16:40:08 2018 +0100

    cherry-ignore: intel/compiler: move nir_lower_bool_to_int32 before nir_lower_locals_to_regs

    pick: This commit is nominated to stable, but fixes commit 11dc1307794
    which is not in the current stable branch.

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dbaed2a39c4ec6ad2763979dae70818f2badc831
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Thu Dec 20 16:28:45 2018 +0100

    cherry-ignore: nir: properly find the entry to keep in copy_prop_vars

    pick: This commit is nominated to stable, but fixes commit b3c61469255
    which is in 18.3 stable. Hence, this commit is considered as nominated
    to 18.3 stable.

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c77e043c3834b28a7ec531d4db47b605707a9669
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Mon Dec 17 10:42:13 2018 +0100

    ac: split 16-bit ssbo loads that may not be dword aligned

    This ends up refactoring visit_load_buffer() a little.

    Fixes: 7e7ee826982 ('ac: add support for 16bit buffer loads')
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108114
    Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=47a1288d969b39b5aff4ada3e05069556d09d8de
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon Dec 17 18:48:17 2018 -0800

    Revert "nir/lower_indirect: Bail early if modes == 0"

        "There's no point in walking the program if we're never going to
        actually lower anything."

    Except we might lower compacted local arrays.  In that case, modes will
    be 0, but there is still lowering to be done.

    This reverts commit 7f75cf2a9408b9af562e033ef6c1d1fd15141421.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109081
    Suggested-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Tested-by: Clayton Craft <clayton.a.craft at intel.com>
    Cc: Kenneth Graunke <kenneth at whitecape.org>
    (cherry picked from commit 29e4b949b45b468c366b9865298391c89ba6642c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=de433d5021f61c5575546375a02d15bdf7cad0b0
Author: Vinson Lee <vlee at freedesktop.org>
Date:   Tue Dec 18 09:42:04 2018 -0800

    meson: Fix libsensors detection.

    Fixes: 5e71efef44b9 ("meson: Add lmsensors support")
    Signed-off-by: Vinson Lee <vlee at freedesktop.org>
    Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
    (cherry picked from commit 0f7ba5758bd8a3e12b8b33ab471336eaa7dd6fbc)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e65a9d3b3fdf7646a4ca32659a7350ca6c4f2c15
Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sun Dec 16 16:35:00 2018 -0800

    meson: Fix typo.

    Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker")
    Signed-off-by: Vinson Lee <vlee at freedesktop.org>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 84f39e5971d77549293a1b8abd479cca2ff4b97e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=391bb79a44e68a13d83b10bfc0540747dc0b3575
Author: Dylan Baker <dylan at pnwbakers.com>
Date:   Tue Dec 4 09:28:10 2018 -0800

    meson: Fix ppc64 little endian detection

    Old versions of meson returned ppc64le as the cpu_family for little
    endian power8 cpus, versions >=0.48 don't do this, so the check wouldn't
    work in that case. This generalizes the check to work for both old and
    new versions of meson.

    Fixes: 34bbb24ce7702658cdc4e9d34a650e169716c39e
           ("meson: Add support for ppc assembly/optimizations")
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
    (cherry picked from commit e430a034b9d2be626557931cd29808a3161889f1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4427e40d4d5e12d28a707c03a68cd16ab2a1302c
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed Jun 20 17:18:30 2018 -0700

    i965/vec4/dce: Don't narrow the write mask if the flags are used

    In an instruction sequence like

                cmp(8).ge.f0.0 vgrf17:D, vgrf2.xxxx:D, vgrf9.xxxx:D
        (+f0.0) sel(8) vgrf1:UD, vgrf8.xyzw:UD, vgrf1.xyzw:UD

    The other fields of vgrf17 may be unused, but the CMP still needs to
    generate the other flag bits.

    To my surprise, nothing in shader-db or any test suite appears to hit
    this.  However, I have a change to brw_vec4_cmod_propagation that
    creates cases where this can happen.  This fix prevents a couple dozen
    regressions in that patch.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Fixes: 5df88c20 ("i965/vec4: Rewrite dead code elimination to use live in/out.")
    (cherry picked from commit 440c051340669e809511c05370d6d703c70f6d0e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5825e93915c06b7c79860b3eab452cf5495ec9b3
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Dec 19 12:46:14 2018 +0100

    cherry-ignore: radv: Fix multiview depth clears

    fixes: This commit requires commits aeaf8dbd097 and 7484bc894b9 which
    did not land in branch.

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3a887700f1fe3923b7293f7b3ee8d8e78071487c
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Fri Dec 14 16:47:09 2018 +0000

    radv: don't set surf_index for stencil-only images

    Fixes: f8d5b377c8b ('radv: set cb base tile swizzles for MRT speedups (v4)')
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116
    Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit bba94a3d85c8799b2441a5d41015091e8903738f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4075f74d18483dc8a847c669a4852f64bb3572e6
Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Mon May 28 13:03:24 2018 +0200

    intel/compiler: do not copy-propagate strided regions to ddx/ddy arguments

    The implementation of these opcodes in the generator assumes that their
    arguments are packed, and it generates register regions based on that
    assumption.

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 391894321161b37a3f8ae1cae4ece6c72ea38bc1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce3f05c2b707998217e0caa967296161b0c16daa
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Dec 19 15:39:56 2018 +0100

    nir/constant_folding: Fix source bit size logic

    Instead of looking at input_sizes[i] which contains the number of
    components for each source, we look at the bit size of input_types[i].
    This fixes a regression in the 1-bit boolean series though I have no
    idea how we haven't seen it before now.

    Fixes: 35baee5dce5 "nir/constant_folding: fix incorrect bit-size check"
    Fixes: 9076c4e289d "nir: update opcode definitions for different bit sizes"
    Reviewed-by: Eric Anholt <eric at anholt.net>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Tested-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    (cherry picked from commit 3595a0abf43be3ce27d88f5939b257a74e90035b)
    [Juan A. Suarez: resolve trivial conflicts]

    Conflicts:
    	src/compiler/nir/nir_opt_constant_folding.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=beec28d21b4fde1254cff2b0437429f475221f7e
Author: Jon Turney <jon.turney at dronecode.org.uk>
Date:   Fri Dec 14 13:20:10 2018 +0000

    glx: Fix compilation with GLX_USE_WINDOWSGL

    Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical
    (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs)

    Include <sys/time.h> again, as functions prototyped by it are used in
    the GLX_USE_WINDOWSGL path.

    Make the include guard around the __glxGetMscRate() definition match the
    one at it's declaration again, as it's referenced from dri_common.c
    which is built for GLX_USE_WINDOWSGL.

    Fixes: a95ec138 ("glx: mandate xf86vidmode only for "drm" dri platforms")
    Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit d512b35b62ff928b880a67887d36f1568aaa5e4b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e621aee78828ffa94498e9561139d7d1f0420f42
Author: Eric Anholt <eric at anholt.net>
Date:   Mon Dec 10 16:47:13 2018 -0800

    v3d: Add missing flagging of SYNCB as a TSY op.

    Fixes: f2e41daac577 ("broadcom/vc5: Update QPU instruction pack/unpack for v4.2.")
    (cherry picked from commit ff80e58b38a13c97a4ee598497e3e7b886918087)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a52d12eec0b1013d149636fed2949ac8b3a35d7c
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Dec 11 16:14:03 2018 -0800

    v3d: Make sure that a thrsw doesn't split a multop from its umul24.

    The thrsw will invalidate rtop, just like accumulators and flags.  Caught
    by simulator assertions in CS imulextended/umulextended tests.

    Fixes: 90269ba35333 ("broadcom/vc5: Use THRSW to enable multi-threaded shaders.")
    (cherry picked from commit 3f9bcf9136af794d44fa4b0802c0d4df6b170175)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=edcbdea5a636982fca9305da59a85cb59318a152
Author: Jan Vesely <jan.vesely at rutgers.edu>
Date:   Thu Dec 13 15:53:42 2018 -0500

    clover: Fix build after clang r348827

    CodeGenOptions were moved to Basic.

    Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
    Reviewed-by: Aaron Watry <awatry at gmail.com>
    Tested-by: Aaron Watry <awatry at gmail.com>
    Reviewed-by: Kai Wasserbäch <kai at dev.carbon-project.org>
    CC: mesa-stable at lists.freedesktop.org
    (cherry picked from commit e4f9a37ace750646fd75fbbdff9b5e77a0b26cfb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7cde3dcf07b6d0e9a36cf4e7e92c09ddc9caac93
Author: Alex Deucher <alexander.deucher at amd.com>
Date:   Fri Dec 7 16:10:33 2018 -0500

    pci_ids: add new vega20 pci id

    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 4db4b3447d5258a26a805766e156ea0a338c95b7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=51f1bd5827608d686bc5203b4c39f58c758bb0ac
Author: Alex Deucher <alexander.deucher at amd.com>
Date:   Fri Dec 7 16:09:16 2018 -0500

    pci_ids: add new vega10 pci ids

    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 56cf25a114436dfc4006296ecef820057f7391b6)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=46e102d963a48d5160d9b005c1c5784aa2d87334
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Tue Dec 11 16:20:40 2018 +0000

    glx: mandate xf86vidmode only for "drm" dri platforms

    Currently we have the three dri "platforms" - drm, apple and windows.

    Since xf86vidmode is a thing only for the drm one, adjust the
    preprocessor guards and correctly check for the dependency.

    v2: terminate the GLX_USE_WINDOWSGL hunk

    Cc: Jon TURNEY <jon.turney at dronecode.org.uk>
    Fixes: 5bc509363b6 ("glx: make xf86vidmode mandatory for direct rendering")
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
    Acked-by: Eric Engestrom <eric.engestrom at intel.com>
    (cherry picked from commit a95ec13879d4f04d01fc04a62503578e85c846a8)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bff2986b3c0b31096af573ee6eada2fffe8b3cfc
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Tue Dec 11 14:02:53 2018 +0000

    virgl: work around bad assumptions in virglrenderer

    Virglrenderer does the wrong thing when given an instance divisor;
    it tries to use the element-index rather than the binding-index as
    the argument to glVertexBindingDivisor(). This worked fine as long
    as there was a 1:1 relationship between elements and bindings,
    which was the case util 19a91841c34 "st/mesa: Use Array._DrawVAO in
    st_atom_array.c.".

    So let's detect instance divisors, and restore a 1:1 relationship in
    that case. This will make old versions of virglrenderer behave
    correctly. For newer versions, we can consider making a better
    interface, where the instance divisor isn't specified per element,
    but rather per binding. But let's save that for another day.

    Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Fixes: 19a91841c34 "st/mesa: Use Array._DrawVAO in st_atom_array.c."
    Reviewed-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
    Tested-By: Gert Wollny <gert.wollny at collabora.com>
    (cherry picked from commit e888f28d1fd9f125fc70b2f5d1b3c42d8f25ae53)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5efd0c35fb701537a1d17b7902b7691f5e1b593e
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Tue Dec 11 12:34:38 2018 +0000

    virgl: wrap vertex element state in a struct

    This just has one member for now; the handle. But this is about to
    change.

    Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Reviewed-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
    Tested-By: Gert Wollny <gert.wollny at collabora.com>
    (cherry picked from commit 8447b64238773db0e365802315772d1819c1923f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c57f3aaa47d02d12ecc2054d71d99fa85bc76e6b
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Fri Dec 14 12:02:26 2018 +0100

    cherry-ignore: meson: libfreedreno depends upon libdrm (for fence support)

    fixes: The changes this commit provides are already included in the
    branch.

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=316e388223943a6849a879206eddf0f8182a23ad
Author: Rob Clark <robdclark at gmail.com>
Date:   Sat Dec 8 13:21:52 2018 -0500

    mesa/st/nir: fix missing nir_compact_varyings

    LinkedTransformFeedback is normally populated, which had nerf'd varying
    packing since the check was introduced.

    Fixes: dbd52585fa9 st/nir: Disable varying packing when doing transform feedback.
    Signed-off-by: Rob Clark <robdclark at gmail.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    (cherry picked from commit cfe8220904b79ee45083970c0325bf59a140e163)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=69396e242bc9b4c45fdba4d0cfe9cfe2c5369b66
Author: Kirill Burtsev <kirill.burtsev at qt.io>
Date:   Wed Dec 5 15:54:27 2018 +0000

    loader: free error state, when checking the drawable type

    Currently we distinguish if the drawable is a window or pixmap by
    checking xcb_present_select_input throws an error or not.

    Yet, we don't always free the error state returned by xcb.

    Cc: Kirill Burtsev <kirill.burtsev at qt.io>
    Cc: Boyan Ding <boyan.j.ding at gmail.com>
    Fixes: 6bd9ba7d074 ("loader: Add dri3 helper")
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    [Emil: add commit message, fixes tag]
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit a539316485ddda074ca1b71aebf4a29b65af87c3)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb04300772b83f2ef19777cb2a1d6cf4919cfa1d
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Oct 9 14:15:12 2018 +0200

    radv: switch on EOP when primitive restart is enabled with triangle strips

    Otherwise, Yakuza hangs the GPU with DXVK. We don't know if
    linetrip and pointlist are affected, so my point is to do that
    only for triangle strips.

    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    (cherry picked from commit d8325f1f07b67c8a31c6786c71e3fd0910bc3b82)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a968e08d9323fa8150b11f4444d07691490b7b89
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Fri Dec 14 09:03:26 2018 +0100

    cherry-ignore: add explicit 18.3 only nominations

    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>