Mesa (staging/18.2): bin/get-pick-list.sh: warn when commit lists invalid sha

[GitLab Mirror]

Module: Mesa
Branch: staging/18.2
Commit: 750e66a954509b1aa769b837f44d42d8d9a3f923
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=750e66a954509b1aa769b837f44d42d8d9a3f923

Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Dec 17 16:25:40 2018 +0000

bin/get-pick-list.sh: warn when commit lists invalid sha

We had cases where people would list old/invalid sha in the commit.
Add a trivial checker to catch those and throw a warning.

CC: Juan A. Suarez <jasuarez at igalia.com>
CC: Dylan Baker <dylan at pnwbakers.com>
CC: mesa-stable at lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Andres Gomez <agomez at igalia.com>
(cherry picked from commit e0dbfc995370756355f28ac31495eab96a410384)

---

 bin/get-pick-list.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
index 08a783f35a..79b7a295ea 100755
--- a/bin/get-pick-list.sh
+++ b/bin/get-pick-list.sh
@@ -38,6 +38,17 @@ is_sha_nomination()
 	if test $fixes_count -eq 0; then
 		return 1
 	fi
+
+	# Throw a warning for each invalid sha
+	while test $fixes_count -gt 0; do
+		# Treat only the current line
+		id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2`
+		fixes_count=$(($fixes_count-1))
+		if ! git show $id &>/dev/null; then
+			echo WARNING: Commit $1 lists invalid sha $id
+		fi
+	done
+
 	return 0
 }