Mesa (master): anv/meson: make sure tests link with -msse2
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Dec 31 16:29:29 UTC 2018
Module: Mesa
Branch: master
Commit: 89679e18a94c5983b66e3dbfb56cb350f1646333
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=89679e18a94c5983b66e3dbfb56cb350f1646333
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Sun Dec 30 22:09:06 2018 +0100
anv/meson: make sure tests link with -msse2
Without this, I get the following error when building the tests using
meson on i686:
---8<---
In file included from ../../../mesa/src/intel/vulkan/anv_private.h:46,
from ../../../mesa/src/intel/vulkan/tests/state_pool_no_free.c:26:
../../../mesa/src/intel/common/gen_clflush.h: In function ‘gen_clflush_range’:
../../../mesa/src/intel/common/gen_clflush.h:37:7: error: implicit declaration of function ‘__builtin_ia32_clflush’; did you mean ‘__builtin_ia32_pause’? [-Werror=implicit-function-declaration]
__builtin_ia32_clflush(p);
^~~~~~~~~~~~~~~~~~~~~~
__builtin_ia32_pause
../../../mesa/src/intel/common/gen_clflush.h: In function ‘gen_flush_range’:
../../../mesa/src/intel/common/gen_clflush.h:45:4: error: implicit declaration of function ‘__builtin_ia32_mfence’; did you mean ‘__builtin_ia32_fnclex’? [-Werror=implicit-function-declaration]
__builtin_ia32_mfence();
^~~~~~~~~~~~~~~~~~~~~
__builtin_ia32_fnclex
---8<---
The errors are generated for each of these files:
- mesa/src/intel/vulkan/tests/state_pool_no_free.c
- mesa/src/intel/vulkan/tests/state_pool.c
- mesa/src/intel/vulkan/tests/block_pool_no_free.c
- mesa/src/intel/vulkan/tests/state_pool_free_list_only.c
This is obviously because gen_clflush.h contains code that uses
intrinsics that are only available with SSE3. Since the driver already
uses SSE3, it seems reasonable to add this to the tests as well.
Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
Reviewed-by: Eric Engeström <eric at engestrom.ch>
---
src/intel/vulkan/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build
index e30e922528..15da828ca8 100644
--- a/src/intel/vulkan/meson.build
+++ b/src/intel/vulkan/meson.build
@@ -233,6 +233,7 @@ if with_tests
executable(
t,
['tests/@0 at .c'.format(t), anv_entrypoints[0], anv_extensions_h],
+ c_args : [ c_sse2_args ],
link_with : libvulkan_intel_test,
dependencies : [dep_libdrm, dep_thread, dep_m, dep_valgrind],
include_directories : [
More information about the mesa-commit
mailing list