Mesa (master): radv: don't support tc-compat on multisample d32s8 at all.

Dave Airlie airlied at kemper.freedesktop.org
Tue Feb 6 19:56:18 UTC 2018


Module: Mesa
Branch: master
Commit: e7e81f362d6dc4fe3a272cdd07724a26391e8f5e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7e81f362d6dc4fe3a272cdd07724a26391e8f5e

Author: Dave Airlie <airlied at redhat.com>
Date:   Tue Feb  6 19:37:48 2018 +0000

radv: don't support tc-compat on multisample d32s8 at all.

RX550 fails
dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_2

So increase the range of the workaround.

Fixes: f4c534ef6 (radv: don't enable tc compat for d32s8 + 4/8 samples (v1.1))

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 src/amd/vulkan/radv_image.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index b4de7255c7..5ac0f72589 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -116,8 +116,8 @@ radv_init_surface(struct radv_device *device,
 		    pCreateInfo->mipLevels <= 1 &&
 		    device->physical_device->rad_info.chip_class >= VI &&
 		    ((pCreateInfo->format == VK_FORMAT_D32_SFLOAT ||
-		      /* for some reason TC compat with 4/8 samples breaks some cts tests - disable for now */
-		      (pCreateInfo->samples < 4 && pCreateInfo->format == VK_FORMAT_D32_SFLOAT_S8_UINT)) ||
+		      /* for some reason TC compat with 2/4/8 samples breaks some cts tests - disable for now */
+		      (pCreateInfo->samples < 2 && pCreateInfo->format == VK_FORMAT_D32_SFLOAT_S8_UINT)) ||
 		     (device->physical_device->rad_info.chip_class >= GFX9 &&
 		      pCreateInfo->format == VK_FORMAT_D16_UNORM)))
 			surface->flags |= RADEON_SURF_TC_COMPATIBLE_HTILE;




More information about the mesa-commit mailing list