Mesa (master): ac: convert nir_op_f2f32 src to a float

Timothy Arceri tarceri at kemper.freedesktop.org
Fri Feb 9 23:49:04 UTC 2018


Module: Mesa
Branch: master
Commit: ef8082baf860cb19cbb8c6435e9144ff16b3429f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ef8082baf860cb19cbb8c6435e9144ff16b3429f

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Fri Feb  9 17:17:31 2018 +1100

ac: convert nir_op_f2f32 src to a float

Fixes the following piglit test:

./bin/arb_vertex_attrib_64bit-check-explicit-location -auto -fbo

Where we would end up with the nir such as:

	vec1 64 ssa_11 = pack_64_2x32_split ssa_9, ssa_10
	vec1 32 ssa_12 = f2f32 ssa_2

And our pack_64_2x32_split nir to llvm code always produces
a 64bit integer as output.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/common/ac_nir_to_llvm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 396627bf1b..cd12805496 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -1957,6 +1957,7 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
 		result = LLVMBuildFPExt(ctx->ac.builder, src[0], ac_to_float_type(&ctx->ac, def_type), "");
 		break;
 	case nir_op_f2f32:
+		src[0] = ac_to_float(&ctx->ac, src[0]);
 		result = LLVMBuildFPTrunc(ctx->ac.builder, src[0], ac_to_float_type(&ctx->ac, def_type), "");
 		break;
 	case nir_op_u2u32:




More information about the mesa-commit mailing list