Mesa (master): gallium/llvmpipe: Fix compiler warnings about ddx/ddy/ddmax.

Eric Anholt anholt at kemper.freedesktop.org
Mon Feb 12 20:49:36 UTC 2018


Module: Mesa
Branch: master
Commit: 7a83be4b28953c9dfc609ad084f57e671310661a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a83be4b28953c9dfc609ad084f57e671310661a

Author: Eric Anholt <eric at anholt.net>
Date:   Sat Feb 10 10:24:14 2018 +0000

gallium/llvmpipe: Fix compiler warnings about ddx/ddy/ddmax.

My gcc doesn't figure out that dims >= 1 (seems reasonable), and doesn't
notice that ddmax is used from the same no_rho_opt as its initialization.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>

---

 src/gallium/auxiliary/gallivm/lp_bld_sample.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample.c b/src/gallium/auxiliary/gallivm/lp_bld_sample.c
index db3d9d65c9..ab9d051c91 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_sample.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_sample.c
@@ -275,7 +275,7 @@ lp_build_rho(struct lp_build_sample_context *bld,
       rho = lp_build_mul(rho_bld, cubesize, rho);
    }
    else if (derivs) {
-      LLVMValueRef ddmax[3], ddx[3], ddy[3];
+      LLVMValueRef ddmax[3] = { NULL }, ddx[3] = { NULL }, ddy[3] = { NULL };
       for (i = 0; i < dims; i++) {
          LLVMValueRef floatdim;
          LLVMValueRef indexi = lp_build_const_int32(gallivm, i);




More information about the mesa-commit mailing list