Mesa (master): i965/icl: Update the comment for maximum number of threads per PSD
Anuj Phogat
aphogat at kemper.freedesktop.org
Fri Feb 16 01:05:06 UTC 2018
Module: Mesa
Branch: master
Commit: e9ad5c9a5d71e7c4312a1ad025b9e5a9c26a10f4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e9ad5c9a5d71e7c4312a1ad025b9e5a9c26a10f4
Author: Anuj Phogat <anuj.phogat at gmail.com>
Date: Fri May 5 13:55:10 2017 -0700
i965/icl: Update the comment for maximum number of threads per PSD
Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/intel/blorp/blorp_genX_exec.h | 9 +++++----
src/mesa/drivers/dri/i965/genX_state_upload.c | 9 +++++----
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h
index ec08b92aad..0fcb94f1c5 100644
--- a/src/intel/blorp/blorp_genX_exec.h
+++ b/src/intel/blorp/blorp_genX_exec.h
@@ -738,11 +738,12 @@ blorp_emit_ps_config(struct blorp_batch *batch,
params->wm_prog_kernel + prog_data->prog_offset_2;
}
- /* 3DSTATE_PS expects the number of threads per PSD, which is always 64;
- * it implicitly scales for different GT levels (which have some # of
- * PSDs).
+ /* 3DSTATE_PS expects the number of threads per PSD, which is always 64
+ * for pre Gen11 and 128 for gen11+; On gen11+ If a programmed value is
+ * k, it implies 2(k+1) threads. It implicitly scales for different GT
+ * levels (which have some # of PSDs).
*
- * In Gen8 the format is U8-2 whereas in Gen9 it is U8-1.
+ * In Gen8 the format is U8-2 whereas in Gen9+ it is U9-1.
*/
if (GEN_GEN >= 9)
ps.MaximumNumberofThreadsPerPSD = 64 - 1;
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
index f1842b36c0..3cb8256807 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -3815,11 +3815,12 @@ genX(upload_ps)(struct brw_context *brw)
ps.SampleMask = genX(determine_sample_mask(brw));
#endif
- /* 3DSTATE_PS expects the number of threads per PSD, which is always 64;
- * it implicitly scales for different GT levels (which have some # of
- * PSDs).
+ /* 3DSTATE_PS expects the number of threads per PSD, which is always 64
+ * for pre Gen11 and 128 for gen11+; On gen11+ If a programmed value is
+ * k, it implies 2(k+1) threads. It implicitly scales for different GT
+ * levels (which have some # of PSDs).
*
- * In Gen8 the format is U8-2 whereas in Gen9 it is U8-1.
+ * In Gen8 the format is U8-2 whereas in Gen9+ it is U9-1.
*/
#if GEN_GEN >= 9
ps.MaximumNumberofThreadsPerPSD = 64 - 1;
More information about the mesa-commit
mailing list