Mesa (master): svga: Fix a leftover debug hack

Thomas Hellstrom thomash at kemper.freedesktop.org
Tue Feb 20 09:38:44 UTC 2018


Module: Mesa
Branch: master
Commit: 80c31f7837cd319910d94d780f5048de6cce0adb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=80c31f7837cd319910d94d780f5048de6cce0adb

Author: Thomas Hellstrom <thellstrom at vmware.com>
Date:   Mon Jan 15 12:51:27 2018 +0100

svga: Fix a leftover debug hack

Fix what appears to be a leftover debug hack.
The hack would force the driver to take a different blit path; possibly,
although unverified, reverting to software blits.

Tested using piglit tests/quick. No related regressions.

Cc: "17.2 17.3 18.0" <mesa-stable at lists.freedesktop.org>
Fixes: 9d81ab7376 (svga: Relax the format checks for copy_region_vgpu10 somewhat)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104625
Reported-by: Grazvydas Ignotas <notasas at gmail.com>
Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/gallium/drivers/svga/svga_pipe_blit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_pipe_blit.c b/src/gallium/drivers/svga/svga_pipe_blit.c
index e98113c385..4b65a69a9e 100644
--- a/src/gallium/drivers/svga/svga_pipe_blit.c
+++ b/src/gallium/drivers/svga/svga_pipe_blit.c
@@ -351,8 +351,8 @@ can_blit_via_surface_copy(struct svga_context *svga,
 
       if (blit_info->src.resource->format != blit_info->src.format ||
           blit_info->dst.resource->format != blit_info->dst.format ||
-          !util_is_format_compatible(src_desc, dst_desc));
-      return FALSE;
+          !util_is_format_compatible(src_desc, dst_desc))
+         return false;
    }
 
    if (svga->render_condition && blit_info->render_condition_enable)




More information about the mesa-commit mailing list