Mesa (master): ac/nir: set the DA field when performing atomics on 3D images
Samuel Pitoiset
hakzsam at kemper.freedesktop.org
Wed Feb 21 08:42:40 UTC 2018
Module: Mesa
Branch: master
Commit: ff83dfb364e2fce7160695579e65e06fcd2164f1
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff83dfb364e2fce7160695579e65e06fcd2164f1
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Feb 20 11:11:42 2018 +0100
ac/nir: set the DA field when performing atomics on 3D images
This doesn't fix anything known but it should definitely be set.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
---
src/amd/common/ac_nir_to_llvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 351e6fa9ef..52ec40fb12 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -3773,7 +3773,8 @@ static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
char coords_type[8];
bool da = glsl_sampler_type_is_array(type) ||
- glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_CUBE;
+ glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_CUBE ||
+ glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_3D;
LLVMValueRef coords = params[param_count++] = get_image_coords(ctx, instr);
params[param_count++] = get_sampler_desc(ctx, instr->variables[0], AC_DESC_IMAGE,
More information about the mesa-commit
mailing list