Mesa (master): mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

Antía Puentes Felpeto apuentes at kemper.freedesktop.org
Fri Feb 23 10:44:55 UTC 2018


Module: Mesa
Branch: master
Commit: e1623b303ccc7a880e34bddef7231dcf230826b3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e1623b303ccc7a880e34bddef7231dcf230826b3

Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Mon Jan 15 10:58:50 2018 +0000

mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

RGB9_E5 should be accepted by RenderbufferStorage if the
EXT_texture_shared_exponent is exposed. It is left to the
implementations to return GL_FRAMEBUFFER_UNSUPPORTED_EXT
when checking the framebuffer completeness if they do not
support rendering in this format.

Discussed in:
https://github.com/KhronosGroup/OpenGL-API/issues/32

This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5

v2: Added more info to the commit message (Antia)

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Antia Puentes <apuentes at igalia.com>

---

 src/mesa/main/fbobject.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index d23916d1ad..c72204e11a 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -1976,6 +1976,9 @@ _mesa_base_fbo_format(const struct gl_context *ctx, GLenum internalFormat)
                ctx->Extensions.ARB_texture_float) ||
               _mesa_is_gles3(ctx) /* EXT_color_buffer_float */ )
          ? GL_RGBA : 0;
+   case GL_RGB9_E5:
+      return (_mesa_is_desktop_gl(ctx) && ctx->Extensions.EXT_texture_shared_exponent)
+         ? GL_RGB: 0;
    case GL_ALPHA16F_ARB:
    case GL_ALPHA32F_ARB:
       return ctx->API == API_OPENGL_COMPAT &&




More information about the mesa-commit mailing list