Mesa (master): gbm: Fix the alpha masks in the GBM format table.

Eric Anholt anholt at kemper.freedesktop.org
Fri Feb 23 23:07:44 UTC 2018


Module: Mesa
Branch: master
Commit: 880573e7370b866c94513f59ad0bb0b10660643f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=880573e7370b866c94513f59ad0bb0b10660643f

Author: Eric Anholt <eric at anholt.net>
Date:   Fri Feb 23 14:55:51 2018 -0800

gbm: Fix the alpha masks in the GBM format table.

Once GBM started looking at the values of the alpha masks, ARGB/ABGR
wouldn't match any more because we had both A and R in the low bits.

Fixes: 2ed344645d65 ("gbm/dri: Add RGBA masks to GBM format table")
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Daniel Stone <daniels at collabora.com>

---

 src/gbm/backends/dri/gbm_dri.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index ed64ad61bf..df20db4021 100644
--- a/src/gbm/backends/dri/gbm_dri.c
+++ b/src/gbm/backends/dri/gbm_dri.c
@@ -562,7 +562,7 @@ static const struct gbm_dri_visual gbm_dri_visuals_table[] = {
    },
    {
      GBM_FORMAT_ARGB8888, __DRI_IMAGE_FORMAT_ARGB8888,
-     { 0x00ff0000, 0x0000ff00, 0x000000ff, 0x000000ff },
+     { 0x00ff0000, 0x0000ff00, 0x000000ff, 0xff000000 },
    },
    {
      GBM_FORMAT_XBGR8888, __DRI_IMAGE_FORMAT_XBGR8888,
@@ -570,7 +570,7 @@ static const struct gbm_dri_visual gbm_dri_visuals_table[] = {
    },
    {
      GBM_FORMAT_ABGR8888, __DRI_IMAGE_FORMAT_ABGR8888,
-     { 0x000000ff, 0x0000ff00, 0x00ff0000, 0x000000ff },
+     { 0x000000ff, 0x0000ff00, 0x00ff0000, 0xff000000 },
    },
    {
      GBM_FORMAT_XRGB2101010, __DRI_IMAGE_FORMAT_XRGB2101010,




More information about the mesa-commit mailing list