Mesa (master): broadcom/vc5: Don't emit component 3/ 4 F16 TLB writes for float/vec2.

Eric Anholt anholt at kemper.freedesktop.org
Wed Jan 3 22:36:11 UTC 2018


Module: Mesa
Branch: master
Commit: 635131a238eb1efa075a6b422ac9add863422cd7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=635131a238eb1efa075a6b422ac9add863422cd7

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Dec 28 15:29:04 2017 -0800

broadcom/vc5: Don't emit component 3/4 F16 TLB writes for float/vec2.

Fixes a simulator assertion failure on
dEQP-GLES3.functional.fragment_out.array.fixed.r8_highp_float.

---

 src/broadcom/compiler/nir_to_vir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/broadcom/compiler/nir_to_vir.c b/src/broadcom/compiler/nir_to_vir.c
index 394e20d207..f998f71659 100644
--- a/src/broadcom/compiler/nir_to_vir.c
+++ b/src/broadcom/compiler/nir_to_vir.c
@@ -1214,7 +1214,8 @@ emit_frag_end(struct v3d_compile *c)
                                                 vir_uniform_ui(c, conf);
                                 }
 
-                                inst = vir_VFPACK_dest(c, vir_reg(QFILE_TLB, 0), b, a);
+                                if (num_components >= 3)
+                                        inst = vir_VFPACK_dest(c, vir_reg(QFILE_TLB, 0), b, a);
                         }
                         break;
                 }




More information about the mesa-commit mailing list