Mesa (master): ac/nir: fix translation of nir_op_frcp for doubles

Timothy Arceri tarceri at kemper.freedesktop.org
Thu Jan 11 22:29:53 UTC 2018


Module: Mesa
Branch: master
Commit: 7b971c828a7aaa507e9cea139f3ed932bbfc890a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b971c828a7aaa507e9cea139f3ed932bbfc890a

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Thu Jan 11 21:11:00 2018 +1100

ac/nir: fix translation of nir_op_frcp for doubles

Without this we end up with the llvm error message:

"Both operands to a binary operator are not of the same type!"

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/common/ac_nir_to_llvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 372a424ce5..7b348d97f0 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -1715,7 +1715,8 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
 		break;
 	case nir_op_frcp:
 		src[0] = ac_to_float(&ctx->ac, src[0]);
-		result = ac_build_fdiv(&ctx->ac, ctx->ac.f32_1, src[0]);
+		result = ac_build_fdiv(&ctx->ac, instr->dest.dest.ssa.bit_size == 32 ? ctx->ac.f32_1 : ctx->ac.f64_1,
+				       src[0]);
 		break;
 	case nir_op_iand:
 		result = LLVMBuildAnd(ctx->ac.builder, src[0], src[1], "");




More information about the mesa-commit mailing list