Mesa (master): radv: Replace an assert with unreachable.

Bas Nieuwenhuizen bnieuwenhuizen at kemper.freedesktop.org
Thu Jan 18 23:40:18 UTC 2018


Module: Mesa
Branch: master
Commit: 0f89f9b8eb4b4f40d9359ebc98ed7f92cd889a83
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f89f9b8eb4b4f40d9359ebc98ed7f92cd889a83

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Wed Jan 17 23:23:02 2018 +0100

radv: Replace an assert with unreachable.

Otherwise we get uninitialized variable warnings for es_vgpr_comp_cnt.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/vulkan/radv_shader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c
index 9819a522d7..3bcaac168a 100644
--- a/src/amd/vulkan/radv_shader.c
+++ b/src/amd/vulkan/radv_shader.c
@@ -424,7 +424,7 @@ radv_fill_shader_variant(struct radv_device *device,
 		} else if (es_type == MESA_SHADER_TESS_EVAL) {
 			es_vgpr_comp_cnt = 3;
 		} else {
-			assert(!"invalid shader ES type");
+			unreachable("invalid shader ES type");
 		}
 
 		/* If offsets 4, 5 are used, GS_VGPR_COMP_CNT is ignored and




More information about the mesa-commit mailing list