Mesa (master): radv: Fix fragment resolve init memory allocation failure paths.
Bas Nieuwenhuizen
bnieuwenhuizen at kemper.freedesktop.org
Sun Jan 21 23:16:13 UTC 2018
Module: Mesa
Branch: master
Commit: 2c802ca66c480a1038e1fe52350e30a27658e78a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c802ca66c480a1038e1fe52350e30a27658e78a
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Jan 21 21:59:26 2018 +0100
radv: Fix fragment resolve init memory allocation failure paths.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
---
src/amd/vulkan/radv_meta_resolve_fs.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/radv_meta_resolve_fs.c
index 99314d94e5..08c9282bf0 100644
--- a/src/amd/vulkan/radv_meta_resolve_fs.c
+++ b/src/amd/vulkan/radv_meta_resolve_fs.c
@@ -319,16 +319,9 @@ create_resolve_pipeline(struct radv_device *device,
&vk_pipeline_info, &radv_pipeline_info,
&device->meta_state.alloc,
pipeline);
-
ralloc_free(vs.nir);
ralloc_free(fs.nir);
- if (result != VK_SUCCESS)
- goto fail;
- return VK_SUCCESS;
-fail:
- ralloc_free(vs.nir);
- ralloc_free(fs.nir);
return result;
}
@@ -339,14 +332,19 @@ radv_device_init_meta_resolve_fragment_state(struct radv_device *device)
res = create_layout(device);
if (res != VK_SUCCESS)
- return res;
+ goto fail;
for (uint32_t i = 0; i < MAX_SAMPLES_LOG2; ++i) {
for (unsigned j = 0; j < ARRAY_SIZE(pipeline_formats); ++j) {
res = create_resolve_pipeline(device, i, pipeline_formats[j]);
+ if (res != VK_SUCCESS)
+ goto fail;
}
}
+ return VK_SUCCESS;
+fail:
+ radv_device_finish_meta_resolve_fragment_state(device);
return res;
}
More information about the mesa-commit
mailing list