Mesa (master): svga: Prevent use after free.

Jose Fonseca jrfonseca at kemper.freedesktop.org
Mon Jan 22 21:12:45 UTC 2018


Module: Mesa
Branch: master
Commit: dcbb224c688bfdacb76107a9816647f64088e67e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dcbb224c688bfdacb76107a9816647f64088e67e

Author: Jose Fonseca <jfonseca at vmware.com>
Date:   Mon Jan 22 15:05:22 2018 +0000

svga: Prevent use after free.

Courtesy of clang static analyzer.

I was hunting for potential sources of memory corruption using Mesa with
a GL trace, and happened to find this (unrelated) issue.

Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

---

 src/gallium/drivers/svga/svga_context.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/svga/svga_context.c b/src/gallium/drivers/svga/svga_context.c
index 546b9f48b1..af16a99b72 100644
--- a/src/gallium/drivers/svga/svga_context.c
+++ b/src/gallium/drivers/svga/svga_context.c
@@ -327,6 +327,7 @@ cleanup:
    util_bitmask_destroy(svga->stream_output_id_bm);
    util_bitmask_destroy(svga->query_id_bm);
    FREE(svga);
+   svga = NULL;
 
 done:
    SVGA_STATS_TIME_POP(svgascreen->sws);




More information about the mesa-commit mailing list