Mesa (master): anv/cmd_buffer: Get rid of the meta query workaround
Jason Ekstrand
jekstrand at kemper.freedesktop.org
Wed Jan 24 08:26:13 UTC 2018
Module: Mesa
Branch: master
Commit: d6c9a89d1324ed2c723cbd3c6d8390691c58dfd2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6c9a89d1324ed2c723cbd3c6d8390691c58dfd2
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Dec 15 09:12:11 2017 -0800
anv/cmd_buffer: Get rid of the meta query workaround
Meta has been gone for a long time.
Tested-by: Józef Kucia <joseph.kucia at gmail.com>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
Cc: "18.0" <mesa-stable at lists.freedesktop.org>
---
src/intel/vulkan/anv_cmd_buffer.c | 1 -
src/intel/vulkan/anv_private.h | 1 -
src/intel/vulkan/genX_query.c | 14 --------------
3 files changed, 16 deletions(-)
diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c
index 69acafaae2..c0270e128f 100644
--- a/src/intel/vulkan/anv_cmd_buffer.c
+++ b/src/intel/vulkan/anv_cmd_buffer.c
@@ -146,7 +146,6 @@ anv_cmd_state_reset(struct anv_cmd_buffer *cmd_buffer)
state->push_constant_stages = 0;
state->restart_index = UINT32_MAX;
state->dynamic = default_dynamic_state;
- state->need_query_wa = true;
state->pma_fix_enabled = false;
state->hiz_enabled = false;
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 5043305ccf..f209dca555 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -1691,7 +1691,6 @@ struct anv_cmd_state {
struct anv_state binding_tables[MESA_SHADER_STAGES];
struct anv_state samplers[MESA_SHADER_STAGES];
struct anv_dynamic_state dynamic;
- bool need_query_wa;
struct anv_push_descriptor_set * push_descriptors[MAX_SETS];
diff --git a/src/intel/vulkan/genX_query.c b/src/intel/vulkan/genX_query.c
index 266163474b..4efcc57e47 100644
--- a/src/intel/vulkan/genX_query.c
+++ b/src/intel/vulkan/genX_query.c
@@ -409,20 +409,6 @@ void genX(CmdBeginQuery)(
ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
ANV_FROM_HANDLE(anv_query_pool, pool, queryPool);
- /* Workaround: When meta uses the pipeline with the VS disabled, it seems
- * that the pipelining of the depth write breaks. What we see is that
- * samples from the render pass clear leaks into the first query
- * immediately after the clear. Doing a pipecontrol with a post-sync
- * operation and DepthStallEnable seems to work around the issue.
- */
- if (cmd_buffer->state.need_query_wa) {
- cmd_buffer->state.need_query_wa = false;
- anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
- pc.DepthCacheFlushEnable = true;
- pc.DepthStallEnable = true;
- }
- }
-
switch (pool->type) {
case VK_QUERY_TYPE_OCCLUSION:
emit_ps_depth_count(cmd_buffer, &pool->bo, query * pool->stride + 8);
More information about the mesa-commit
mailing list