Mesa (master): anv: correct a duplicate check in an assert

Grazvydas Ignotas notaz at kemper.freedesktop.org
Wed Jan 24 23:12:05 UTC 2018


Module: Mesa
Branch: master
Commit: 0cc7370733e9d20999d13c4c8565f0c91846a45c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0cc7370733e9d20999d13c4c8565f0c91846a45c

Author: Grazvydas Ignotas <notasas at gmail.com>
Date:   Tue Jan 23 00:44:36 2018 +0200

anv: correct a duplicate check in an assert

Looks like checking both sources was intended, instead of the first one
twice. Found with Coccinelle, coccinellery/xand/xand.cocci semantic patch.

Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

---

 src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
index 978a8a57c7..6775f9b464 100644
--- a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
+++ b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c
@@ -147,7 +147,7 @@ lower_res_reindex_intrinsic(nir_intrinsic_instr *intrin,
     * array elements are sequential.  A resource_reindex just turns into an
     * add of the two indices.
     */
-   assert(intrin->src[0].is_ssa && intrin->src[0].is_ssa);
+   assert(intrin->src[0].is_ssa && intrin->src[1].is_ssa);
    nir_ssa_def *new_index = nir_iadd(b, intrin->src[0].ssa,
                                         intrin->src[1].ssa);
 




More information about the mesa-commit mailing list