Mesa (master): nir: mark unused space in packed_tex_data

Tapani Pälli tpalli at kemper.freedesktop.org
Mon Jan 29 06:15:00 UTC 2018


Module: Mesa
Branch: master
Commit: d0343bef6680cc660ba691bbed31a2a1b7449f79
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0343bef6680cc660ba691bbed31a2a1b7449f79

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Fri Jan 26 11:26:18 2018 +0200

nir: mark unused space in packed_tex_data

This change cleans following scary warnings in valgrind output
when disk cache is being written:

   ==6532== Uninitialised byte(s) found during client check request
   ==6532==    at 0x14423FAD: blob_write_bytes (blob.c:152)
   ==6532==    by 0x144240FB: blob_write_uint32 (blob.c:194)
   ==6532==    by 0x144001A5: write_tex (nir_serialize.c:613)

and later (loads of):

   ==6532== Use of uninitialised value of size 8
   ==6532==    at 0x62FCD9E: crc32_z (in /usr/lib64/libz.so.1.2.11)
   ==6532==    by 0x13F65014: util_hash_crc32 (crc32.c:127)
   ==6532==    by 0x13F5DABA: cache_put (disk_cache.c:947)

Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

---

 src/compiler/nir/nir_serialize.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/compiler/nir/nir_serialize.c b/src/compiler/nir/nir_serialize.c
index 54a00c81d6..9fe46a675f 100644
--- a/src/compiler/nir/nir_serialize.c
+++ b/src/compiler/nir/nir_serialize.c
@@ -585,6 +585,7 @@ union packed_tex_data {
       unsigned component:2;
       unsigned has_texture_deref:1;
       unsigned has_sampler_deref:1;
+      unsigned unused:10; /* Mark unused for valgrind. */
    } u;
 };
 




More information about the mesa-commit mailing list