Mesa (staging/18.1): anv/android: Fix type error in call to vk_errorf()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 13 20:38:50 UTC 2018


Module: Mesa
Branch: staging/18.1
Commit: 20527c871119a11f61001fdd2f1775c462f895e4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=20527c871119a11f61001fdd2f1775c462f895e4

Author: Chad Versace <chadversary at chromium.org>
Date:   Wed Jun 27 20:22:23 2018 -0700

anv/android: Fix type error in call to vk_errorf()

In a single call to vk_errorf() in the Android code, the arguments were
swapped. The bug has existed since day one. Chrome OS used to forgive
the warning, but it is now a compilation error.

CC: <mesa-stable at lists.freedesktop.org>
Fixes: 053d4c32 "anv: Implement VK_ANDROID_native_buffer (v9)"
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
(cherry picked from commit be5fc0d7f114250d37597b38ef53711f2f66bc4f)

---

 src/intel/vulkan/anv_android.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 7e07dbaaa4..d453fb8c3e 100644
--- a/src/intel/vulkan/anv_android.c
+++ b/src/intel/vulkan/anv_android.c
@@ -174,7 +174,7 @@ anv_image_from_gralloc(VkDevice device_h,
       goto fail_create;
 
    if (bo->size < image->size) {
-      result = vk_errorf(device, device->instance,
+      result = vk_errorf(device->instance, device,
                          VK_ERROR_INVALID_EXTERNAL_HANDLE_KHR,
                          "dma-buf from VkNativeBufferANDROID is too small for "
                          "VkImage: %"PRIu64"B < %"PRIu64"B",




More information about the mesa-commit mailing list