Mesa (master): radv: do not set pending_reset_query in BeginCommandBuffer()
Samuel Pitoiset
hakzsam at kemper.freedesktop.org
Fri Mar 2 08:44:48 UTC 2018
Module: Mesa
Branch: master
Commit: c133a3411bbf47c2ba7d9cdae7e35a64fe276068
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c133a3411bbf47c2ba7d9cdae7e35a64fe276068
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Mar 1 10:53:49 2018 +0100
radv: do not set pending_reset_query in BeginCommandBuffer()
This is just useless for two reasons:
1) flush_bits is not set accordingly, so nothing will be flushed
in BeginQuery().
2) we always flush caches in EndCommandBuffer(), so if a reset
is done in a previous command buffer we are safe.
Cc: "18.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Alex Smith <asmith at feralinteractive.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
---
src/amd/vulkan/radv_cmd_buffer.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index cfdc531acd..2b41baea3d 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1930,13 +1930,6 @@ VkResult radv_BeginCommandBuffer(
cmd_buffer->status = RADV_CMD_BUFFER_STATUS_RECORDING;
- /* Force cache flushes before starting a new query in case the
- * corresponding pool has been resetted from a different command
- * buffer. This is because we have to flush caches between reset and
- * begin if the compute shader path has been used.
- */
- cmd_buffer->pending_reset_query = true;
-
return result;
}
More information about the mesa-commit
mailing list