Mesa (master): radv: drop assert on bindingDescriptorCount > 0

Dave Airlie airlied at kemper.freedesktop.org
Wed Mar 14 06:55:12 UTC 2018


Module: Mesa
Branch: master
Commit: 3b0f2081b5dc351d40d67b99f8f1def551a8374d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3b0f2081b5dc351d40d67b99f8f1def551a8374d

Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Mar  8 10:15:12 2018 +1000

radv: drop assert on bindingDescriptorCount > 0

The spec is pretty clear that this can be 0, and that it operates
as a reserved binding.

Fixes:
dEQP-VK.binding_model.descriptor_update.empty_descriptor.uniform_buffer

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 src/amd/vulkan/radv_descriptor_set.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
index daff7b2fcd..3d56f8c217 100644
--- a/src/amd/vulkan/radv_descriptor_set.c
+++ b/src/amd/vulkan/radv_descriptor_set.c
@@ -137,7 +137,6 @@ VkResult radv_CreateDescriptorSetLayout(
 		}
 
 		set_layout->size = align(set_layout->size, alignment);
-		assert(binding->descriptorCount > 0);
 		set_layout->binding[b].type = binding->descriptorType;
 		set_layout->binding[b].array_size = binding->descriptorCount;
 		set_layout->binding[b].offset = set_layout->size;




More information about the mesa-commit mailing list