Mesa (master): mesa: fix leaking ParameterValueOffset

Tapani Pälli tpalli at kemper.freedesktop.org
Tue Mar 20 11:26:45 UTC 2018


Module: Mesa
Branch: master
Commit: 604cac9f739264377acb22a657bf745762a94656
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=604cac9f739264377acb22a657bf745762a94656

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Tue Mar 20 08:55:28 2018 +0200

mesa: fix leaking ParameterValueOffset

==15115== 48 bytes in 1 blocks are definitely lost in loss record 16 of 66
==15115==    at 0x4C2EC15: realloc (vg_replace_malloc.c:785)
==15115==    by 0x8602C3E: _mesa_reserve_parameter_storage (prog_parameter.c:212)
==15115==    by 0x8602D1E: _mesa_add_parameter (prog_parameter.c:252)
==15115==    by 0x86032C4: _mesa_add_sized_state_reference (prog_parameter.c:384)
==15115==    by 0x8603324: _mesa_add_state_reference (prog_parameter.c:409)

Fixes: edded12376 "mesa: rework ParameterList to allow packing"
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

---

 src/mesa/program/prog_parameter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c
index 88821cfba1..2bc1b6db6e 100644
--- a/src/mesa/program/prog_parameter.c
+++ b/src/mesa/program/prog_parameter.c
@@ -180,6 +180,7 @@ _mesa_free_parameter_list(struct gl_program_parameter_list *paramList)
       free((void *)paramList->Parameters[i].Name);
    }
    free(paramList->Parameters);
+   free(paramList->ParameterValueOffset);
    _mesa_align_free(paramList->ParameterValues);
    free(paramList);
 }




More information about the mesa-commit mailing list