Mesa (master): meson: simplify omx logic
Eric Engeström
eric_engestrom at kemper.freedesktop.org
Thu Mar 22 10:10:57 UTC 2018
Module: Mesa
Branch: master
Commit: 795b465c50930a39e9040e219c0f7ee405be6ae1
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=795b465c50930a39e9040e219c0f7ee405be6ae1
Author: Mathias Fröhlich <mathias.froehlich at web.de>
Date: Fri Mar 16 06:34:35 2018 +0100
meson: simplify omx logic
and let's make sure `with_gallium_omx` is never 'auto' and can only be
one of [bellagio, tizonia, disabled].
Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
---
meson.build | 30 ++++++++++++++----------------
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/meson.build b/meson.build
index 24cad58c61..0a94eec514 100644
--- a/meson.build
+++ b/meson.build
@@ -496,42 +496,40 @@ elif not (with_gallium_r600 or with_gallium_radeonsi or with_gallium_nouveau)
error('OMX state tracker requires at least one of the following gallium drivers: r600, radeonsi, nouveau.')
endif
endif
-with_gallium_omx = _omx
dep_omx = []
dep_omx_other = []
-if with_gallium_omx == 'bellagio' or with_gallium_omx == 'auto'
+if ['auto', 'bellagio'].contains(_omx)
dep_omx = dependency(
- 'libomxil-bellagio', required : with_gallium_omx == 'bellagio'
+ 'libomxil-bellagio', required : _omx == 'bellagio'
)
if dep_omx.found()
pre_args += '-DENABLE_ST_OMX_BELLAGIO'
with_gallium_omx = 'bellagio'
endif
endif
-if with_gallium_omx == 'tizonia' or with_gallium_omx == 'auto'
- if not (with_dri and with_egl)
- if with_gallium_omx == 'tizonia'
- error('OMX-Tizonia state tracker requires dri and egl')
- else
- with_gallium_omx == 'disabled'
- endif
- else
+if ['auto', 'tizonia'].contains(_omx)
+ if with_dri and with_egl
dep_omx = dependency(
'libtizonia', version : '>= 0.10.0',
- required : with_gallium_omx == 'tizonia',
+ required : _omx == 'tizonia',
)
dep_omx_other = [
- dependency('libtizplatform', required : with_gallium_omx == 'tizonia'),
- dependency('tizilheaders', required : with_gallium_omx == 'tizonia'),
+ dependency('libtizplatform', required : _omx == 'tizonia'),
+ dependency('tizilheaders', required : _omx == 'tizonia'),
]
if dep_omx.found() and dep_omx_other[0].found() and dep_omx_other[1].found()
pre_args += '-DENABLE_ST_OMX_TIZONIA'
with_gallium_omx = 'tizonia'
- else
- with_gallium_omx = 'disabled'
endif
+ elif _omx == 'tizonia'
+ error('OMX-Tizonia state tracker requires dri and egl')
endif
endif
+if _omx == 'auto'
+ with_gallium_omx = 'disabled'
+else
+ with_gallium_omx = _omx
+endif
omx_drivers_path = get_option('omx-libs-path')
if with_gallium_omx != 'disabled'
More information about the mesa-commit
mailing list