Mesa (18.1): st/omx/enc: fix blit setup for YUV LoadImage
Dylan Baker
dbaker at kemper.freedesktop.org
Fri May 4 16:38:37 UTC 2018
Module: Mesa
Branch: 18.1
Commit: 7a1f220b26d21390493073713a509ac53a36f896
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a1f220b26d21390493073713a509ac53a36f896
Author: Leo Liu <leo.liu at amd.com>
Date: Fri Apr 27 08:32:41 2018 -0400
st/omx/enc: fix blit setup for YUV LoadImage
The blit here involves scaling since it's copying from I8 format to R8G8 format.
Half of source will be filtered out with PIPE_TEX_FILTER_NEAREST instruction, it
looks that GPU always uses the second half as source. Currently we use "1" as
the start point of x for R, then causing 1 source pixel of U component shift to
right. So "-1" should be the start point for U component.
Cc: 18.0 18.1 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 1c5f4f4e17f74d823d9e38c678e40e9f49e2c053)
---
src/gallium/state_trackers/omx/vid_enc_common.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/gallium/state_trackers/omx/vid_enc_common.c b/src/gallium/state_trackers/omx/vid_enc_common.c
index 874dd3a1c8..2aa739da22 100644
--- a/src/gallium/state_trackers/omx/vid_enc_common.c
+++ b/src/gallium/state_trackers/omx/vid_enc_common.c
@@ -353,7 +353,7 @@ OMX_ERRORTYPE enc_LoadImage_common(vid_enc_PrivateType * priv, OMX_VIDEO_PORTDEF
blit.src.resource = inp->resource;
blit.src.format = inp->resource->format;
- blit.src.box.x = 0;
+ blit.src.box.x = -1;
blit.src.box.y = def->nFrameHeight;
blit.src.box.width = def->nFrameWidth;
blit.src.box.height = def->nFrameHeight / 2 ;
@@ -367,11 +367,11 @@ OMX_ERRORTYPE enc_LoadImage_common(vid_enc_PrivateType * priv, OMX_VIDEO_PORTDEF
blit.dst.box.depth = 1;
blit.filter = PIPE_TEX_FILTER_NEAREST;
- blit.mask = PIPE_MASK_G;
+ blit.mask = PIPE_MASK_R;
priv->s_pipe->blit(priv->s_pipe, &blit);
- blit.src.box.x = 1;
- blit.mask = PIPE_MASK_R;
+ blit.src.box.x = 0;
+ blit.mask = PIPE_MASK_G;
priv->s_pipe->blit(priv->s_pipe, &blit);
priv->s_pipe->flush(priv->s_pipe, NULL, 0);
More information about the mesa-commit
mailing list