Mesa (master): i965: Only emit VF cache invalidations when the high bits changes

Kenneth Graunke kwg at kemper.freedesktop.org
Tue May 29 19:18:00 UTC 2018


Module: Mesa
Branch: master
Commit: 3ac5fbadfd8644d30fce9ff267cb811ad157996a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ac5fbadfd8644d30fce9ff267cb811ad157996a

Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue May 29 17:28:07 2018 +0100

i965: Only emit VF cache invalidations when the high bits changes

Commit 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit
addressing bugs with softpin.") tried to only emit the VF invalidate if
the high bits changed, but it accidentally always set need_invalidate to
true; causing it to emit unconditionally emit the pipe control before
every primitive.

Fixes: 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin.")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106708
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

---

 src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
index b485e2cf81..88fde9d12f 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -504,7 +504,7 @@ static void
 vf_invalidate_for_vb_48bit_transitions(struct brw_context *brw)
 {
 #if GEN_GEN >= 8
-   bool need_invalidate = true;
+   bool need_invalidate = false;
    unsigned i;
 
    for (i = 0; i < brw->vb.nr_buffers; i++) {




More information about the mesa-commit mailing list