Mesa (master): vbo: Test for VBO_SAVE_PRIM_WEAK in _mesa_prim::mode is false.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Nov 1 05:41:59 UTC 2018


Module: Mesa
Branch: master
Commit: 1387b4d53385c6827d785b3c858d9e585ee8883e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1387b4d53385c6827d785b3c858d9e585ee8883e

Author: Mathias Fröhlich <mathias.froehlich at web.de>
Date:   Mon Oct 29 06:13:19 2018 +0100

vbo: Test for VBO_SAVE_PRIM_WEAK in _mesa_prim::mode is false.

When setting the _mesa_prim::mode field we always filter out
all non OpenGL primitive mode bits. So this tested bit cannot be
there anymore and the test evaluates to zero.
The zero is removed with the next patch to ease review.

Reviewed-by: Brian Paul <brianp at vmware.com>
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>

---

 src/mesa/vbo/vbo_save_loopback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/vbo/vbo_save_loopback.c b/src/mesa/vbo/vbo_save_loopback.c
index 36b1f71eb5..5d4d9c574e 100644
--- a/src/mesa/vbo/vbo_save_loopback.c
+++ b/src/mesa/vbo/vbo_save_loopback.c
@@ -227,7 +227,7 @@ _vbo_loopback_vertex_list(struct gl_context *ctx,
    const struct _mesa_prim *prims = node->prims;
    const GLuint prim_count = node->prim_count;
    for (GLuint i = 0; i < prim_count; i++) {
-      if ((prims[i].mode & VBO_SAVE_PRIM_WEAK) && _mesa_inside_begin_end(ctx)) {
+      if ((0) && _mesa_inside_begin_end(ctx)) {
          loopback_weak_prim(ctx, &prims[i]);
       } else {
          loopback_prim(ctx, buffer, &prims[i], wrap_count, stride, la, nr);




More information about the mesa-commit mailing list