Mesa (master): anv: use image aspects rather than computed ones

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Nov 13 18:57:38 UTC 2018


Module: Mesa
Branch: master
Commit: 8b00d3d6ebd3a9e6694a43168a76dc9ce6e8c8a0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8b00d3d6ebd3a9e6694a43168a76dc9ce6e8c8a0

Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date:   Tue Oct 30 23:44:05 2018 +0000

anv: use image aspects rather than computed ones

This shouldn't make any difference but I feel uneasy to use the
expanded aspects that do not represent the image in its entirety. If
we ever change the implementation of the anv_image_aspect_to_plane()
helper, this is safer.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

---

 src/intel/vulkan/anv_image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index b284ed4b40..4a0284cf21 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -1321,7 +1321,7 @@ anv_CreateImageView(VkDevice _device,
    uint32_t iaspect_bit, vplane = 0;
    anv_foreach_image_aspect_bit(iaspect_bit, image, expanded_aspects) {
       uint32_t iplane =
-         anv_image_aspect_to_plane(expanded_aspects, 1UL << iaspect_bit);
+         anv_image_aspect_to_plane(image->aspects, 1UL << iaspect_bit);
       VkImageAspectFlags vplane_aspect =
          anv_plane_to_aspect(iview->aspect_mask, vplane);
       struct anv_format_plane format =




More information about the mesa-commit mailing list