Mesa (staging/18.3): radv: only expose VK_SUBGROUP_FEATURE_ARITHMETIC_BIT for VI+

[GitLab Mirror]

Module: Mesa
Branch: staging/18.3
Commit: c64a78ec0a5daf862e10d8a4fb931348167b6d3f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c64a78ec0a5daf862e10d8a4fb931348167b6d3f

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Nov  7 17:06:27 2018 +0100

radv: only expose VK_SUBGROUP_FEATURE_ARITHMETIC_BIT for VI+

Inclusive and exclusives scan are missing because older chips
don't have llvm.amdgcn.update.dpp.

This fixes crashes with dEQP-VK.subgroups.arithmetic.*.

CC: mesa-stable at lists.freedesktop.org
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 0dcd99c6870aae5b15c8709a8afcc942d116c976)

---

 src/amd/vulkan/radv_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index d68111c25b..92254bed2e 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1058,12 +1058,12 @@ void radv_GetPhysicalDeviceProperties2(
 			 * is fixed in LLVM.
 			 */
 			properties->supportedOperations =
-							VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
 							VK_SUBGROUP_FEATURE_BASIC_BIT |
 							VK_SUBGROUP_FEATURE_BALLOT_BIT |
 							VK_SUBGROUP_FEATURE_QUAD_BIT;
 			if (pdevice->rad_info.chip_class >= VI) {
 				properties->supportedOperations |=
+							VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
 							VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
 							VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT;
 			}