Mesa (staging/18.3): bin/get-pick-list.sh: prefix output with "[stable] "

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 16 12:05:12 UTC 2018


Module: Mesa
Branch: staging/18.3
Commit: fc99358bdc57494c91ffe26dbd224747f648b1aa
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc99358bdc57494c91ffe26dbd224747f648b1aa

Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Thu Nov  8 15:05:14 2018 +0000

bin/get-pick-list.sh: prefix output with "[stable] "

With later commits we'll fold all the different scripts into one.
Add the explicit prefix, so that we know the origin of the nomination

v2:
 - pass the sha as argument to the function
 - swap $tag = none for an else statment (Juan)
 - grep -q instead of using a variable (Eric)
 - print the tag and commit oneline separately (Eric)

v3:
 - drop unused "tag=none" assignment (Juan)
 - typo nomination

Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com> (v2)
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit fac10169bbad2da918ef07a62c01e0b321508cfe)

---

 bin/get-pick-list.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
index ba741cc411..2c7d87db0c 100755
--- a/bin/get-pick-list.sh
+++ b/bin/get-pick-list.sh
@@ -7,6 +7,14 @@
 # $ bin/get-pick-list.sh
 # $ bin/get-pick-list.sh > picklist
 # $ bin/get-pick-list.sh | tee picklist
+#
+# The output is as follows:
+# [nomination_type] commit_sha commit summary
+
+is_stable_nomination()
+{
+	git show --summary "$1" | grep -q -i -o "CC:.*mesa-stable"
+}
 
 # Use the last branchpoint as our limit for the search
 latest_branchpoint=`git merge-base origin/master HEAD`
@@ -32,6 +40,13 @@ do
 		continue
 	fi
 
+	if is_stable_nomination "$sha"; then
+		tag=stable
+	else
+		continue
+	fi
+
+	printf "[ %8s ] " "$tag"
 	git --no-pager show --summary --oneline $sha
 done
 




More information about the mesa-commit mailing list