Mesa (staging/18.3): Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 16 12:05:12 UTC 2018


Module: Mesa
Branch: staging/18.3
Commit: 65926d5d949a00954917d2c2f715f27960907a8b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=65926d5d949a00954917d2c2f715f27960907a8b

Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Wed Oct 17 16:57:01 2018 +0200

Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"

This reverts commit 647c2b90e96a9ab8571baf958a7c67c1e816911a. There was
one recently-introduced bug in ac for dvec3 loads, but the other test
failures were actually bugs in the tests. See
https://github.com/KhronosGroup/VK-GL-CTS/commit/9429e621c48848d224e35f30a1ae45a4a079922c

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit ba94a00c7ce1514372bfe9b35c8e0c7fb8cd710e)

---

 src/amd/vulkan/radv_device.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 92254bed2e..957d6ac9ba 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -1054,13 +1054,11 @@ void radv_GetPhysicalDeviceProperties2(
 			    (VkPhysicalDeviceSubgroupProperties*)ext;
 			properties->subgroupSize = 64;
 			properties->supportedStages = VK_SHADER_STAGE_ALL;
-			/* TODO: Enable VK_SUBGROUP_FEATURE_VOTE_BIT when wwm
-			 * is fixed in LLVM.
-			 */
 			properties->supportedOperations =
 							VK_SUBGROUP_FEATURE_BASIC_BIT |
 							VK_SUBGROUP_FEATURE_BALLOT_BIT |
-							VK_SUBGROUP_FEATURE_QUAD_BIT;
+							VK_SUBGROUP_FEATURE_QUAD_BIT |
+							VK_SUBGROUP_FEATURE_VOTE_BIT;
 			if (pdevice->rad_info.chip_class >= VI) {
 				properties->supportedOperations |=
 							VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |




More information about the mesa-commit mailing list