Mesa (18.3): radv: Align large buffers to the fragment size.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Nov 29 12:04:21 UTC 2018
Module: Mesa
Branch: 18.3
Commit: ec659efcbaae8fe3030437f9a46d036f4fe93b33
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec659efcbaae8fe3030437f9a46d036f4fe93b33
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Mon Nov 26 03:28:05 2018 +0100
radv: Align large buffers to the fragment size.
Improves performance in Talos by about 15% (and significant improvements
in RotR and possibly other but did not bench with final patch) on
kernel 4.19 and earlier.
On 4.20+ a similar effect comes from
433ca054949a "drm/amdgpu: try allocating VRAM as power of two"
v2: Do not impact the alignment of the physical memory.
Reviewed-by: Dave Airlie <airlied at redhat.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
CC: <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 6569644bb6e1f58fd739d83bd4dc42e6af6b6097)
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
index 25764d93f6..482cf0f665 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
@@ -304,8 +304,12 @@ radv_amdgpu_winsys_bo_create(struct radeon_winsys *_ws,
return NULL;
}
+ unsigned virt_alignment = alignment;
+ if (size >= ws->info.pte_fragment_size)
+ virt_alignment = MAX2(virt_alignment, ws->info.pte_fragment_size);
+
r = amdgpu_va_range_alloc(ws->dev, amdgpu_gpu_va_range_general,
- size, alignment, 0, &va, &va_handle,
+ size, virt_alignment, 0, &va, &va_handle,
(flags & RADEON_FLAG_32BIT ? AMDGPU_VA_RANGE_32_BIT : 0) |
AMDGPU_VA_RANGE_HIGH);
if (r)
More information about the mesa-commit
mailing list