Mesa (master): 24 new commits

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Oct 3 12:43:42 UTC 2018


URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=08bff097e136042aa5e5a0c99b1b67871525e5fe
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Sep 7 14:58:03 2018 +0100

    meson: remove invalid "opencl" llvm component
    
    Seeming copy/paste mistake from configure.ac which uses $2 for the
    component and $3 for the fancy name printing.
    
    Cc: Dylan Baker <dylan at pnwbakers.com>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe8be81b4a525fec355e2f80c254711981ce0dbd
Author: Emil Velikov <emil.l.velikov at gmail.com>
Date:   Mon Sep 24 16:01:38 2018 +0100

    Revert "mesa: remove unnecessary 'sort by year' for the GL extensions"
    
    This reverts commit 3d81e11b49366b5636b8524ba0f8c7076e3fdf34.
    
    As reported by Federico, some games require the 'sort by year' since
    they truncate the extensions which do not fit the fixed size string
    array.
    
    Seemingly I did not consider that, as the documentation (both Mesa and
    Nvidia) mentions about program crashes ... which are worked around by
    setting the env. variable.
    
    This commit reinstates the workaround and enhances the documentation.
    
    Cc: Marek Olšák <maraeo at gmail.com>
    Cc: Ian Romanick <idr at freedesktop.org>
    Reported-by: Federico Dossena <info at fdossena.com>
    Fixes: 3d81e11b493 ("mesa: remove unnecessary 'sort by year' for the GL
    extensions")
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Reviewed-by: Roland Scheidegger <sroland at vmware.com>
    Tested-by: Federico Dossena <info at fdossena.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=91ff8b1dd9bb5fe605d30e61dc4d8b69e391c0c8
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:17 2018 +0100

    mesa: reorder and document the tokens in glheader.h
    
    Split into different sections, document each one as well as strange
    cases like GL_ATI_texture_compression_3dc.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5f70964b1d7cc34b98a8e8d23018d7890a8cad54
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:16 2018 +0100

    mesa: remove duplicate declarations from glheader.h
    
    Remove all the desktop GL and GLX entries from the list.
    Former are pulled by the gl.h and glext.h includes at the top while the
    latter are no longer needed.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=01b92916afc239383eb2ebb469fe61d6d106a3a7
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:15 2018 +0100

    i965: reference __DRI_ATTRIB_SWAP_COPY token over the GLX one
    
    Earlier commit updated the code to use the DRI tokens, yet forgot to
    update the comment.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e04b2c037644b2da9728b5efcdb4386ac0c3356e
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:14 2018 +0100

    i915: reference __DRI_ATTRIB_SWAP_COPY token over the GLX one
    
    Earlier commit updated the code to use the DRI tokens, yet forgot to
    update the comment.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d26b122ee88dae51fb230ecb0987811eabd5046b
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:13 2018 +0100

    dri/common: move the required GLX_* token definitions locally
    
    Will allow us to remove even bigger hack elsewhere. But more
    importantly, we should not be using _any_ GLX tokens in DRI.
    
    Document the gory details about the current side-effects.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ef53669af215b6eba8188f2c6f330f98914b87b
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:35:12 2018 +0100

    dri/common: use __DRI_ATTRIB_SWAP* instances when describing db_modes
    
    Somewhat recently Thomas Hellstrom added the respective DRI tokens
    and updated the drivers. Update the documentation to match reality.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6a6760139c5301544636cd23e014db11559d25a
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:27 2018 +0100

    egl/x11: remove eglSwap* surface check
    
    Already handled further up in eglapi.c.
    
    To make things a tiny bit strange, X11+DRI3 was doing the wrong thing by
    returning EGL_FALSE (+ no error), while X11+DRI2 was returning EGL_TRUE.
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Eric Engestrom <eric.engestrom at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=803074199636bb99f6438906a1e93c7533246b82
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:26 2018 +0100

    egl/surfaceless: remove eglSwap* stubs
    
    The API validation in eglapi.c already returns if the surface type is
    !window.
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Cc: Gurchetan Singh <gurchetansingh at chromium.org>
    Cc: Chad Versace <chadversary at chromium.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a370e278d3bba4b0304d4a1e6de1e9a4f9c26266
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:25 2018 +0100

    egl/drm: remove eglSwap* surface check
    
    Already handled further up in eglapi.c
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=91ccb59ff48126ce7e9893a781646b22057f023a
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:24 2018 +0100

    egl/android: remove eglSwap* surface check
    
    Already handled further up in eglapi.c
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8f66743ca2cd781e912a3998196bf2ef1b9f8f4c
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:23 2018 +0100

    egl: make eglSwapBuffers* a no-op for !window surfaces
    
    Analogous to the previous commit - the spec says the function is a
    no-op when a pbuffer or pixmap surface is used.
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Cc: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=64b4ccde0cab4bbabba8abbf206ec5aa53399821
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Sep 3 13:05:22 2018 +0100

    egl: make eglSwapInterval a no-op for !window surfaces
    
    As the spec says, the function is a no-op when the surface is not a
    window one.
    
    That spec implies that EGL_TRUE should be returned in that case, yet
    the ARM driver seems to return EGL_FALSE + EGL_BAD_SURFACE.
    
    The Nvidia driver returns EGL_TRUE. We follow that behaviour until a
    decision is made.
    
    https://gitlab.khronos.org/egl/API/merge_requests/17
    
    Cc: samiuddi <sami.uddin.mohammad at intel.com>
    Cc: Erik Faye-Lund <kusmabite at gmail.com>
    Cc: Tomasz Figa <tfiga at chromium.org>
    Cc: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c231b49c533cc4a2d5ecf2b48580753fdf8b8759
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Aug 17 13:51:47 2018 +0100

    freedreno: add the a6xx sources to the Android build
    
    Add the files otherwise things just won't build.
    Haven't actually tested it, but it's a small step in the right
    direction.
    
    Fixes: de3b34df973 ("freedreno: Add a6xx backend")
    Cc: Kristian H. Kristensen <hoegsberg at chromium.org>
    Cc: Rob Clark <robdclark at gmail.com>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Rob Clark <robdclark at gmail.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7419b224139b47ea98d1bc4c5dab7370076b214f
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Thu Aug 30 17:24:16 2018 +0100

    pipe-loader: add a dup() in pipe_loader_sw_probe_kms
    
    The pipe_loader_release API closes the fd given, even if the pipe-loader
    should _not_ take ownership of it.
    
    With earlier commit we fixed pipe_loader_drm_probe_fd, and now with
    cover the final piece.
    
    Note that unlike the DRM case, here the caller _did_ forget to dup
    before using it ... most likely leading to all sorts of fun.
    
    Don't forget the close in the error path. Seems like the things are a
    bit leaky/asymmetrical with the semi-recent config work. But we can shave
    that yak another day ;-)
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ccc435e7ad92bb0ba77d3fdb48c7127ba71239e
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Aug 29 18:13:14 2018 +0100

    pipe-loader: move dup(fd) within pipe_loader_drm_probe_fd
    
    Currently pipe_loader_drm_probe_fd takes ownership of the fd given.
    To match that, pipe_loader_release closes it.
    
    Yet we have many instances which do not want the change of ownership,
    and thus duplicate the fd before passing it to the pipe-loader.
    
    Move the dup() within pipe-loader, explicitly document that and document
    all the cases through the codebase.
    
    A trivial git grep -2 pipe_loader_release makes things as obvious as it
    gets ;-)
    
    Cc: Leo Liu <leo.liu at amd.com>
    Cc: Thomas Hellstrom <thellstrom at vmware.com>
    Cc: Axel Davy <davyaxel0 at gmail.com>
    Cc: Patrick Rudolph <siro at das-labor.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>
    Reviewed-by: Axel Davy <davyaxel0 at gmail.com> (for nine)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b8d1b313cd01bb916898d8bb92a566534e37677
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Aug 29 18:13:13 2018 +0100

    st/nine: do not double-close the fd on teardown
    
    As the newly introduced comment says:
     The pipe loader takes ownership of the fd
    
    Thus, there's no need to close it again.
    
    Cc: Patrick Rudolph <siro at das-labor.org>
    Cc: Axel Davy <davyaxel0 at gmail.com>
    Cc: mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Axel Davy <davyaxel0 at gmail.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa9df82f67c7dda41bd3c9aab1487ec10fadca96
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Sep 5 17:09:10 2018 +0100

    mesa: fold _glapi_check_multithread() back into _mesa_make_current
    
    With commit c6c0f947142, back in 2006 Brian removed the
    _glapi_check_multithread() call from core mesa - _mesa_make_current.
    
    It was done to remove fairly awkward #ifdef guard which caused subtle
    differences in core mesa.
    
    Since that guard is long gone, we can drop the duplication and
    reintroduce the call in core.
    
    Note that the function is was missing when using EGL + classic dri HW
    drivers. Yet on TLS builds it's a no-op, so we're safe.
    
    Any non TLS users - more or less anything !Linux (or even musl on Linux
    up-to semi-recently) may have experienced problems.
    
    v2: don't remove the call from swrast - move it to core (Eric)
    
    Cc: Eric Anholt <eric at anholt.net>
    Cc: Brian Paul <brianp at vmware.com>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Brian Paul <brianp at vmware.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d081ad2aa25c5673ec1927fca81e6ac65de4b1b1
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Aug 29 18:14:02 2018 +0100

    vl/dri3: do full teardown on screen_destroy
    
    Earlier commit added support for 'front_buffers', erroneously adding a
    return in vl_dri3_screen_destroy. Effectively leaking a lot of state.
    
    Fixes: 8d7ac0a4e4d ("vl/dri3: implement DRI3 BufferFromPixmap")
    Cc: Leo Liu <leo.liu at amd.com>
    Cc: Christian König <christian.koenig at amd.com>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Leo Liu <leo.liu at amd.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1301674c393671b407eab30aa66bdea6977b1ac8
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Aug 24 14:06:00 2018 +0100

    st/dri: make swrast_no_present member of dri_screen
    
    Just like the dri2 options, this is better suited in the dri_screen
    struct.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=80b62e2d6d2559a2c3f76e4ac06b9386a576d0e3
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Aug 24 14:05:59 2018 +0100

    st/dri: inline dri2_buffer.h within dri2.c
    
    The header was used only by dri2.c, containing a two-member struct and cast wrapper.
    Just inline it where it's used/needed.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=89c2c386c02ef7bc56a11769b0d617261d6a37ea
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Aug 24 14:05:58 2018 +0100

    st/xa: remove unused xa_screen::d[s]_depth_bits_last
    
    Unused since the initial import.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ade4b10e2d2729da3fccf415be486ccc79e1fa2
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Aug 24 14:05:57 2018 +0100

    mesa: use C99 initializer in get_gl_override()
    
    The overrides array contains entries indexed on the gl_api enum.
    Use a C99 initializer to make it a bit more obvious.
    
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>




More information about the mesa-commit mailing list