Mesa (master): virgl, vtest: Correct the transfer size calculation

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sat Oct 6 11:16:19 UTC 2018


Module: Mesa
Branch: master
Commit: 5d7858f1517eb0961811e4106ba11c011d7002e3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5d7858f1517eb0961811e4106ba11c011d7002e3

Author: Gert Wollny <gert.wollny at collabora.com>
Date:   Thu Oct  4 16:40:07 2018 +0200

virgl, vtest: Correct the transfer size calculation

The transfer size used in virglrenderer refers to uint32_t, so one
must add 3 and then divide by 4 instead of adding 3/4 which is a no-op
with integers.

Fixes: b3b82fe8ea virgl/vtest: add vtest driver

Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>

---

 src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c b/src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c
index 4d20a63ad6..ce565ee76c 100644
--- a/src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c
+++ b/src/gallium/winsys/virgl/vtest/virgl_vtest_socket.c
@@ -295,8 +295,10 @@ int virgl_vtest_send_transfer_cmd(struct virgl_vtest_winsys *vws,
    vtest_hdr[VTEST_CMD_LEN] = VCMD_TRANSFER_HDR_SIZE;
    vtest_hdr[VTEST_CMD_ID] = vcmd;
 
+   /* The host expects the size in dwords so calculate the rounded up
+    * value here. */
    if (vcmd == VCMD_TRANSFER_PUT)
-      vtest_hdr[VTEST_CMD_LEN] += data_size + 3 / 4;
+      vtest_hdr[VTEST_CMD_LEN] += (data_size + 3) / 4;
 
    cmd[0] = handle;
    cmd[1] = level;




More information about the mesa-commit mailing list