Mesa (master): st/mesa: calculate buffer size correctly for packed uniforms

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Oct 30 22:38:01 UTC 2018


Module: Mesa
Branch: master
Commit: 9ec4a5ef29cd94c7d810cad5aa58c0c59148c88f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9ec4a5ef29cd94c7d810cad5aa58c0c59148c88f

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Mon Oct 29 20:27:08 2018 +1100

st/mesa: calculate buffer size correctly for packed uniforms

Fixes: edded1237607 ("mesa: rework ParameterList to allow packing")

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/mesa/state_tracker/st_atom_constbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c
index 6455e612e4..fa147b8968 100644
--- a/src/mesa/state_tracker/st_atom_constbuf.c
+++ b/src/mesa/state_tracker/st_atom_constbuf.c
@@ -92,7 +92,7 @@ st_upload_constants(struct st_context *st, struct gl_program *prog)
    /* update constants */
    if (params && params->NumParameters) {
       struct pipe_constant_buffer cb;
-      const uint paramBytes = params->NumParameters * sizeof(GLfloat) * 4;
+      const uint paramBytes = params->NumParameterValues * sizeof(GLfloat);
 
       /* Update the constants which come from fixed-function state, such as
        * transformation matrices, fog factors, etc.  The rest of the values in




More information about the mesa-commit mailing list