Mesa (master): util/gen_xmlpool: Don't use len to test for container emptiness
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Oct 31 23:39:23 UTC 2018
Module: Mesa
Branch: master
Commit: 465cfcb2663fa732041627e5a35c6cadb7851e75
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=465cfcb2663fa732041627e5a35c6cadb7851e75
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Oct 24 12:30:03 2018 -0700
util/gen_xmlpool: Don't use len to test for container emptiness
This is a very common python anti-pattern. Not using length allows us to
go through faster C paths, but has the same meaning.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
---
src/util/xmlpool/gen_xmlpool.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/xmlpool/gen_xmlpool.py b/src/util/xmlpool/gen_xmlpool.py
index 078bced733..f1983c7251 100644
--- a/src/util/xmlpool/gen_xmlpool.py
+++ b/src/util/xmlpool/gen_xmlpool.py
@@ -182,7 +182,7 @@ def main():
with io.open(args.template, mode="rt", encoding='utf-8') as template:
descMatches = []
for line in template:
- if len(descMatches) > 0:
+ if descMatches:
matchENUM = reENUM.match(line)
matchDESC_END = reDESC_END.match(line)
if matchENUM:
@@ -201,16 +201,16 @@ def main():
matchDESC = reDESC.match(line)
matchDESC_BEGIN = reDESC_BEGIN.match(line)
if matchDESC:
- assert len(descMatches) == 0
+ assert not descMatches
expandMatches([matchDESC], translations, output)
elif matchDESC_BEGIN:
- assert len(descMatches) == 0
+ assert not descMatches
descMatches = [matchDESC_BEGIN]
else:
output.write(line)
- if len(descMatches) > 0:
+ if descMatches:
print("Warning: unterminated description at end of file.", file=sys.stderr)
expandMatches(descMatches, translations, output)
More information about the mesa-commit
mailing list