Mesa (18.2): 59 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Sep 19 21:44:49 UTC 2018
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5f2764356796a8a50fba75840d03968a4bf23652
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Wed Sep 19 11:08:24 2018 +0200
cherry-ignore: radv: fix descriptor pool allocation size
fixes: this commit was reverted by commit 95bb7d82ca8.
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc622c08152f0bb92567c953640bf1b796ecae08
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Sep 11 12:55:45 2018 -0500
nir/opt_if: Re-materialize derefs in use blocks before peeling loops
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107879
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 864c780566b8782c4fc69b4337db768223717bd8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=36aa46c2ecb1860a0029cb567310db5007f1c72a
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Sep 11 12:51:09 2018 -0500
nir/loop_unroll: Re-materialize derefs in use blocks before unrolling
When we're about to re-arrange a bunch of blocks, it's a good idea to
make sure that we don't have deref uses crossing block boundaries.
Otherwise we may end up with a deref going through a phi and that would
be bad.
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 0796c3934ebfe3448acf2d63f478f51c08e33046)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f1305c32c1cd4f7c59ef5dfb2eac33339edabc70
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Sep 11 12:15:22 2018 -0500
nir: Add a small pass to rematerialize derefs per-block
This pass re-materializes deref instructions on a per-block basis to
ensure that every use of a deref occurs in the same block as the
instruction which uses it.
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 7d1d1208c2b38890fe065b6431ef2e3b7166bae4)
[Juan A. Suarez: resolve trivial conflicts]
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Conflicts:
src/compiler/nir/nir_deref.c
Squashed with:
nir: add initializer data to fix MSVC compile error
CC: Jason Ekstrand <jason at jlekstrand.net>
Fixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs
per-block")
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
(cherry picked from commit 0c82e3603e195e7b0b3ba39caada6d3ff070076f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3781c4cbf49fdafa56d08dad21ea5a6451f0a70a
Author: Kenneth Feng <kenneth.feng at amd.com>
Date: Thu Jul 26 10:53:33 2018 +0800
amd: Add Picasso device id
No changes here compared to Raven.
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Huang Rui <ray.huang at amd.com>
Signed-off-by: Kenneth Feng <kenneth.feng at amd.com>
Signed-off-by: Huang Rui <ray.huang at amd.com>
Cc: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 4490fce16631fbc098f2fcf3f2c4b73f32a974a5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1ce0c521cd8d017ceb252fd682e626bcc9bd7813
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Wed Sep 12 20:50:34 2018 +1000
Revert "radeonsi: avoid syncing the driver thread in si_fence_finish"
This reverts commit bc65dcab3bc48673ff6180afb036561a4b8b1119.
This was manually reverted. Reverting stops the menu hanging in
some id tech games such as RAGE and Wolfenstein The New Order.
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107891
(cherry picked from commit 7a992fcfa059b0db0f07bc3eb38050eaab7aaf34)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f1f82d2eb0f8af9e0085ede51df081769357ce1c
Author: Fritz Koenig <frkoenig at google.com>
Date: Fri Sep 14 11:40:49 2018 -0700
mesa: FramebufferParameteri parameter checking
Missing break; causes parameter checking to
never pass GL_FRAMEBUFFER_FLIP_Y_MESA parameters.
Fixes: 318c265160 ("mesa: GL_MESA_framebuffer_flip_y extension [v4]")
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit 60d0c0d062b543b85a354e5266aa974fcdc36290)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f92aa390321da632ed34c1bbf476f14f97df723b
Author: Fritz Koenig <frkoenig at google.com>
Date: Mon Sep 10 12:11:16 2018 -0700
mesa: Additional FlipY applications
Instances where direction was determined based on
winsys or user fbo and should be determined based on
FlipY.
Key STATE_FB_WPOS_Y_TRANSFORM for of FlipY instead of
_mesa_is_user_fbo. This corrects gl_FragCoord usage
when applying GL_MESA_framebuffer_flip_y.
Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]")
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit ba6cc32cf9337804d744f234a196c97923c84360)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d2b6f842b4acb62882ff892cb7a4cf0bf260e8cf
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Sep 16 02:50:34 2018 +0200
radv: Use build ID if available for cache UUID.
To get an useful UUID for systems that have a non-useful mtime
for the binaries.
I started using SHA1 to ensure we get reasonable mixing in the
various possibilities and the various build id lengths.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit d17443a459383fdd7018fa879134f05b5daff1e1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e86804eab2cb39c3e49cecbfe07e9f104bb28933
Author: Gert Wollny <gert.wollny at collabora.com>
Date: Mon Sep 10 12:39:44 2018 +0200
mesa/texture: Also check for LA texture when querying intensity component size
Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity
format is provided by the driver. However, when calling
glGetTexLevelParameteriv(..., GL_TEXTURE_INTENSITY_SIZE, ...)
mesa will return a zero size because the actually used format has no
intensity channel and as a fallback only the sizes of the red/green
channels are checked.
Also checking for LA sizes in the allocated texture resolves this problem.
v2: Only check alpha channel size and return it (Marek)
L and A size are always the same in this case.
Fixes (on virgl):
ext_framebuffer_multisample-fast-clear GL_ARB_texture_float *
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107832
Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 47e01e77d8b658606527f048cda786440f7fbe85)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2f9795d6b3fd555125f62539e0ad356bf85a235e
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Sep 14 16:34:22 2018 -0500
anv/query: Write both dwords in emit_zero_queries
Each query slot is a uint64_t and we were only zeroing half of it.
Fixes: 7ec6e4e68980 "anv/query: implement multiview interactions"
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 07e214f1ce263edcecb674d6d2f48569fa1d12ed)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=152e12f36bbb213047684965938e6f044c319af5
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Sep 12 17:16:50 2018 -0700
i965/fs: Don't propagate conditional modifiers from integer compares to adds
No shader-db changes on any Intel platform... which probably explains
why no bugs have been bisected to this problem since it landed in Mesa
18.1. :( The commit mentioned below is in 18.2, so 18.1 would need a
slightly different fix (due to code refactoring).
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Fixes: 77f269bb560 "i965/fs: Refactor propagation of conditional modifiers from compares to adds"
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com> (reviewed the original patch)
Cc: Matt Turner <mattst88 at gmail.com> (reviewed the original patch)
(cherry picked from commit df9dbc03d3df37c10f2d7b73124f8b3fd7a2518f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d42bf4f0eefc06df6791fcd898dfa98989b41190
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Wed Sep 12 09:48:41 2018 +0200
virgl: adjust strides when mapping temp-resources
When we're mapping temp-resources, we clip the resource to the
transfer-box, which means the stride might not be correct any more.
So let's update the stride from the temp-resource, and recompute the
layer-stride.
This fixes crashes when running dEQP with --deqp-gl-config-name=rgba8888d24s8ms4
Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Fixes: a8987b88ff1 "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit fa5e9f1f73f64ac089f8efd5b101a77d06d22fcd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b58be3590daa62aa814c31d6fd3a79903098c1d
Author: Pierre Moreau <pierre.morrow at free.fr>
Date: Tue Dec 5 00:51:04 2017 +0100
nvir: Always split 64-bit IMAD/IMUL operations
Those operations do not map to actual hardware instructions, therefore
those should always be lowered to 32-bit instructions.
Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations"
Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Signed-off-by: Karol Herbst <kherbst at redhat.com>
(cherry picked from commit 21b92b3464193a203e069f50c21ebec146ae0215)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=051880fc209d872e95794b1f2ef44e0084707d98
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Thu Sep 6 11:21:53 2018 +0100
winsys/virgl: avoid unintended behavior
If we end up never taking the loop that writes ret, we can end up with
an uninitialized value, and if we're *really* unlucky, that value can
be -1, causing us to go down an error-path instead of a success path.
This was obviously not intended, so let's just initialize this to zero.
Noticed by Valgrind:
Conditional jump or move depends on uninitialised value(s)
at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348)
by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170)
by 0xBA605AC: virgl_resource_create (virgl_resource.c:60)
by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344)
by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390)
by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136)
by 0xBCFCC6E: st_create_context_priv (st_context.c:414)
by 0xBCFD3CD: st_create_context (st_context.c:590)
by 0xBBB30CA: st_api_create_context (st_manager.c:896)
by 0xB981E76: dri_create_context (dri_context.c:155)
by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473)
by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309)
by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78)
Fixes: a8987b88ff1 ("virgl: add driver for virtio-gpu 3D (v2)")
Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
(cherry picked from commit eaa718588ee97241cdbfea0b49bc30d93a99667c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f2f969add125da862c7a00900899c15c75167e9f
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Sep 16 12:28:33 2018 +0200
radv: Only allow 16 user SGPRs for compute on GFX9+.
Apparently for compute there are only 16 instead of the 32 for the
graphics path.
Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit 0dd8189f159258ad8684036b0d696dbb58a268ca)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1ab5f8addd58f55efbeeed07ace8b564fbb22d72
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Sep 16 12:17:00 2018 +0200
radv: Set the user SGPR MSB for Vega.
Otherwise using 32 user SGPRs would be broken.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit d97c892584cd0641913de2635689c6b59c98816e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f354ac60bdc23f3137e8a8191385236afa1dbd8c
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Sun Aug 26 23:38:12 2018 +0200
android: broadcom/cle: export the broadcom top level path headers
Fixes the following building error in vc4 build:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_render_cl.c:34:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_drv.h:27:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_simulator_validate.h:34:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_context.h:39:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_cl.h:56:
gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h:12:10:
fatal error: 'cle/v3d_packet_helpers.h' file not found
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
Acked-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
(cherry picked from commit cc3b99bb48769ccd018b781338b548306af5046b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7fbd3177dceecc7e6a8674cf90d0f77bbc35b4a0
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Sun Aug 26 23:11:02 2018 +0200
android: broadcom/cle: add gallium include path
Fixes the following building error:
In file included from external/mesa/src/broadcom/cle/v3d_decoder.c:38:
In file included from external/mesa/src/broadcom/cle/v3d_packet_helpers.h:29:
external/mesa/src/gallium/auxiliary/util/u_math.h:42:10:
fatal error: 'pipe/p_compiler.h' file not found
^~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
Acked-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
(cherry picked from commit 9158e0bd82ffdad4baf46221bccbbb3fe4764c11)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ef541926ceca6dd7935e22dacd012f56de8de30
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Sat Aug 25 18:17:23 2018 +0200
android: broadcom/genxml: fix collision with intel/genxml header-gen macro
Fixes the following building error, happening when building both intel and broadcom:
Gen Header: libmesa_broadcom_genxml_32 <= v3d_packet_v21_pack.h
FAILED: gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h
/bin/bash -c "python external/mesa/src/broadcom/cle/gen_pack_header.py \
external/mesa/src/broadcom/cle/v3d_packet_v21.xml \
> gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h"
Traceback (most recent call last):
File "external/mesa/src/broadcom/cle/gen_pack_header.py", line 626, in <module>
p = Parser(sys.argv[2])
IndexError: list index out of range
header-gen macro is already defined by Intel genxml building rules
and the existing header-gen does not have the $(PRIVATE_VER) argument,
infact the bash command line logged in the building error is missing
exactly $(PRIVATE_VER) argument
Renaming the macro as pack-header-gen in src/broadcom/Android.genxml.mk
solves the building error, another possible way is to keep the gen rules
commands expanded and not use the macros.
Fixes: 7f80a9ff13 ("vc4: Introduce XML-based packet header generation like Intel's.")
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
Acked-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Signed-off-by: Mauro Rossi <issor.oruam at gmail.com>
(cherry picked from commit 3341429d74099b436c3824164837eebd47029ded)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa7a9dca2395eca08c6356166768b9304efb6a3b
Author: Josh Pieper <jjp at pobox.com>
Date: Sun Sep 9 22:03:27 2018 -0400
st/mesa: Validate the result of pipe_transfer_map in make_texture (v2)
When using Freecad, I was getting intermittent segfaults inside of
mesa. I traced it down to this path in st_cb_drawpixels.c where the
result of pipe_transfer_map wasn't being checked. In my case, it was
returning NULL because nouveau_bo_new returned ENOENT. I'm by no
means a mesa developer, but this patch solves the problem for me and
seems reasonable enough.
v2: Marek - also unmap the PBO and release the texture, and call
the make_texture function sooner for less cleanup
Cc: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 936e0dcd619bc092b9869b4be2e1b20c3631131f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40b930c982a6449af24120009d054f6128afa4e5
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 15:40:09 2018 +0200
radv: fix setting global locations for indirect descriptors
Indirect descriptors only need one entry, we don't have to
emit a location for every descriptors.
Fixes GPU hangs with new CTS:
dEQP-VK.binding_model.descriptorset_random.*
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 9de062ef207c6062d1fabb70209f4bbc9dc4732d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a103bc9b1f17eee7a9bb3490f13ebbb5c14a8326
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 15:40:08 2018 +0200
radv: fix flushing indirect descriptors
Let say, we first bind a graphics pipeline that needs indirect
descriptors sets. The userdata pointers will be emitted at draw
time. Then if we bind a compute pipeline that doesn't need any
indirect descriptors, the driver will re-emit them for all
grpahics stages.
To avoid this to happen, just check the bind point type.
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 748f4cce183007587a6688ef25ad5f9dbea5c33c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d2527c944bcea2adb4cd1b31a2784e50ef06090
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 15:40:07 2018 +0200
radv: fix GPU hangs with 32-bit indirect descriptors
LLVM 6 isn't affected.
Fixes GPU hangs with new CTS:
dEQP-VK.binding_model.descriptorset_random.*
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 063264db5be2941746fa58f164cdc803362753a9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1655fbd40d1b48343150c4c67fd1ad21696e9ec3
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 15:40:06 2018 +0200
radv: handle loc->indirect correctly for the first descriptor
This was wrong for descriptor #0 when all of them are indirect.
This is because indirect_offset was 0 and we emitted a
"normal" descriptor pointer for nothing.
While we are at it remove
radv_userdata_info::indirect_offset which is useless.
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit aa3020592964344c7032396d159e4ab2df743587)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8de8af1b9090871a8fde2b5c6a439d407dc474e7
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 15:40:05 2018 +0200
radv: bump the maximum number of arguments to 64
Bumping to 64 should be safe enough.
Fixes some crashes with new CTS:
dEQP-VK.binding_model.descriptorset_random.*
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit b9f6521157ab55073eec528cacc1f3b567e49503)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b03b6173a9c522d22d84d245590840c944edbea0
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 23:20:38 2018 +0200
radv: fix VK_EXT_conditional_rendering visibility
It's actually just the opposite.
This fixes the new Sascha conditionalrender demo.
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit abdf396cbeaec2bfe9da2fd773d42fa3022ca8b5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9b52e8fde933f92440837333d06719154a1ca79e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 12 22:54:27 2018 +0200
radv: fix function names for VK_EXT_conditional_rendering
Otherwise they are not exported.
CC: 18.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Dave Airlie <airlied at redhat.com
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit d4bf954fe61ec231be2bfa5e059f0fb7f6150bd1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4b667224d6ddd5d42a1349729337ce68a1afca9
Author: Michel Dänzer <michel.daenzer at amd.com>
Date: Tue Sep 4 12:18:19 2018 +0200
loader/dri3: Only wait for back buffer fences in dri3_get_buffer
We don't need to wait before drawing to the fake front buffer, as front
buffer rendering by definition is allowed to produce artifacts.
Fixes hangs in some cases when re-using the fake front buffer, due to it
still being busy (i.e. in use for presentation).
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/106404
Bugzilla: https://bugs.freedesktop.org/107757
Tested-by: Olivier Fourdan <ofourdan at redhat.com>
Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>
(cherry picked from commit aefac10fecc9ec70feb5923ce3200902f67182ba)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fe3ce2aa3410a7787881db9ad729d6248b61c67
Author: Sergii Romantsov <sergii.romantsov at gmail.com>
Date: Fri Sep 7 12:43:41 2018 +0300
mesa/meson: 32bit xmlconfig linkage
Building of 32bit mesa with meson causes linkage issue:
"undefined reference to `util_get_process_name'"
Fixed by adding link-with mesa_util for xmlconfig primary.
v2: Removed '[]', commit message corrected.
v3: Reverted changes in gbm and glx libraries.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843
Fixes: 2e1e6511f76370870b5cd "util: extract get_process_name from xmlconfig.c"
Cc: Marek Olšák <marek.olsak at amd.com>
Cc: Dylan Baker <dylan at pnwbakers.com>
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
(cherry picked from commit bbe551f3eab793a18cd427098cf8563040c0b56f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87a05c22fbbcffaa8493a17393b36c96740cde84
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Aug 29 08:32:29 2018 +1000
virgl: don't send a shader create with no data. (v2)
This fixes the situation where we'd send a shader with just the
header and no data.
piglit/glsl-max-varyings test was causing this to happen, and
the renderer fix was breaking it.
v2: drop fprintf
Fixes: a8987b88ff1d "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
(cherry picked from commit 240af6149477beb06fdcfc4b0295921448c0fe47)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a7346667450a80c04a4133461f9725a4f667155
Author: Christopher Egert <cme3000 at gmail.com>
Date: Sat Sep 8 02:16:48 2018 +0200
radeon: fix ColorMask
Since commit af3685d14936844f79e6f372b4b258e29375f21b various OpenGL applications regressed
on the classic mesa radeon driver.
Signed-off-by: Christopher Egert <cme3000 at gmail.com>
CC: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 51995f69204e8a751cb1a3e502e013acf7fff031)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=196baf24d5bd31f8e253960fcdeaab29cd112161
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Mon Sep 10 20:34:00 2018 +0200
radv: Support v3 of VK_EXT_vertex_attribute_divisor.
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
CC: 18.2 <mesa-stable at lists.freedesktop.org>
(cherry picked from commit f6e09db2e613c215257b80f40957d580165b5ddf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3c91874faade9ca3ee6f2ea18814df89c2664a5
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Sep 10 12:05:41 2018 -0500
anv: Support v3 of VK_EXT_vertex_attribute_divisor
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 6f00785765cb43b3288e32a6d5d69545cc3b7ef6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d7c88997f894fbdb81b24e36007283a36fa808d
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Sep 10 12:07:51 2018 -0500
vulkan: Update the XML and headers to 1.1.84
Acked-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 34a17a48d440add1da619efd054b50b210cd869b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ad3151a02dc5bd285967307effbafb7d5512201a
Author: Marek Olšák <marek.olsak at amd.com>
Date: Fri Aug 24 23:00:37 2018 -0400
ac: revert new LLVM 7.0 behavior for fdiv
Cc: 18.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
(cherry picked from commit a5f35aa742c3f1e2fae6a6c2fb53f92822f0cb70)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b2e888770ce167468703fccde49c63cd86121f7
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Aug 28 14:59:25 2018 -0400
radeonsi: fix printing a BO list into ddebug reports
important for debugging
Cc: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
(cherry picked from commit 662db03577377cd0acca279ca482ea8e9a4e1704)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5807386559f116d45377a7a42cd5881888868ca
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Aug 28 15:49:31 2018 -0400
r600: fix HTILE for NPOT textures with mipmapping
Cc: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
(cherry picked from commit da72b6296cfa5c5fa92d840d8a69c55df19d13f5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1aa9e7f97305d988f7b25e094ce973a240527419
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Aug 28 14:39:09 2018 -0400
winsys/radeon: fix CMASK fast clear for NPOT textures with mipmapping on SI/CI
Cc: 18.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
(cherry picked from commit d4e52281aa9c1acc92619736da8b67d8c02ce380)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=075313416a88a0cffdc99882764892bd90c49825
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Aug 28 15:49:31 2018 -0400
radeonsi: fix HTILE for NPOT textures with mipmapping on SI/CI
VI uses addrlib so it's unaffected.
Cc: 18.1 18.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
(cherry picked from commit a1b9a00f82db79e59e4a743d52bb62c998584690)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd6303a4400781c3ac020d2b9846574467ad6589
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Aug 21 20:43:57 2018 -0500
anv: Clamp scissors to the framebuffer boundary
The Vulkan 1.1.81 spec says:
"It is legal for offset.x + extent.width or offset.y + extent.height
to exceed the dimensions of the framebuffer - the scissor test still
applies as defined above. Rasterization does not produce fragments
outside of the framebuffer, so such fragments never have the scissor
test performed on them."
Elsewhere, the Vulkan 1.1.81 spec says:
"The application must ensure (using scissor if necessary) that all
rendering is contained within the render area, otherwise the pixels
outside of the render area become undefined and shader side effects
may occur for fragments outside the render area. The render area
must be contained within the framebuffer dimensions."
Unfortunately, there's some room for interpretation here as to what the
consequences are of having the render area set to exactly the
framebuffer dimensions and having a scissor that is larger than the
framebuffer. Given that GL and other APIs provide automatic clipping to
the framebuffer, it makes sense that applications would assume that
Vulkan does this as well. It costs us very little to play it safe and
just clamp client-provided scissors to the framebuffer dimensions.
Fortunately, the user is required to provide us with at least one
scissor so we don't need to handle the case where they don't.
Fixes: fb2a5ceb3264 "anv: Emit DRAWING_RECTANGLE once at driver..."
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 465e5a868cd58ca7c4ff7476e98231ffd4f3d2bf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ded225eb9870ef7ab3c60de2876daeb3d0168c41
Author: Eric Anholt <eric at anholt.net>
Date: Fri Aug 24 15:45:37 2018 -0700
v3d: Fix setup of the VCM cache size.
There were two bugs working together to make things mostly work: I wasn't
dividing the VPM output size available by the size of a batch (vertex),
but I also had the size of the VPM reduced by a factor of 8.
Fixes dEQP-GLES3.functional.vertex_array_objects.all_attributes and it
seems also my intermittent varying failures.
Fixes: 1561e4984eb0 ("v3d: Emit the VCM_CACHE_SIZE packet.")
(cherry picked from commit a91b158bd9e1b6bc08f1d5ac350cd8b68e372042)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f20c0a004e3e8ed4f56114af445ac9eed9e19e6
Author: Sergii Romantsov <sergii.romantsov at gmail.com>
Date: Thu Sep 6 12:59:47 2018 +0300
i965/tools: 32bit compilation with meson
Building of 32bit mesa with meson causes issue:
"implicit declaration of function ‘__builtin_ia32_clflush’".
Fixed by adding msse2 compilation flag.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843
Fixes: 314879f7fec0 (i965: Fix asynchronous mappings on !LLC platforms.)
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 97fcccb25ed5f55139c03ebc1c71742f0f25f683)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <agomez at igalia.com>
Conflicts:
src/intel/tools/meson.build
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5333eba63a9a515fb02c0f9b249cf53e86c941d9
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Aug 21 20:40:50 2018 -0500
anv: Disable the vertex cache when tessellating on SKL GT4
I have no idea if I'm correct about what's going wrong or if this is the
correct fix. However, in my multiple weeks of banging my head on this
hang, a VUE reference counting bug seems to match all the symptoms and
it definitely fixes the hang.
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107280
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit b08b4b2b25b201df2d667cf70d7f99475e5c7aec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9909102335294670952ff507d1448f2da4b43cb3
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Aug 21 17:14:38 2018 -0500
anv: Re-emit vertex buffers when the pipeline changes
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance
data step rate, and pitch come from the pipeline.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit c643c5e18d7c647afc6dcc450183b81a62a40998)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=320dd62ce18375244b73c1a9e386461f569549b9
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Sep 7 00:40:54 2018 -0500
i965: Workaround the gen9 hw astc5x5 sampler bug
gen9 hardware has a bug in the sampler cache that can cause GPU hangs
whenever an texture with aux compression enabled is in the sampler cache
together with an ASTC5x5 texture. Because we can't control what the
client binds at any given time, we have two options: resolve the CCS or
decompresss the ASTC. Doing a CCS or HiZ resolve is far less drastic
and will likely have a smaller performance impact.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
Tested-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
(cherry picked from commit f9e630e23dfa3de815026a08e7e767e2ed90da0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ed365a7fffde6cd17889d708b17f66a4a9509eb
Author: Eric Anholt <eric at anholt.net>
Date: Thu Sep 6 13:37:37 2018 -0700
v3d: Fix SRC_ALPHA_SATURATE blending for RTs without alpha.
Fixes
dEQP-GLES3.functional.fragment_ops.blend.default_framebuffer.rgb_func_alpha_func.dst.src_alpha_saturate_src_alpha_saturate
and friends with --deqp-egl-config-name=rgb565d0s0
Cc: "18.2" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit f73f748323ef5a421ffd8fa0f02afd9627e31023)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9dff29fda5376acf2315848cf054e986a6ba6247
Author: Sergii Romantsov <sergii.romantsov at gmail.com>
Date: Thu Sep 6 11:07:45 2018 +0300
intel: compiler option msse2 and mstackrealign
Seems in case of 32-bit library, usage of msse2 makes
some stack corruption or incorrect instructions.
Usage with mstackrealign fixes that case.
v2: Fixed meson.
v3: Definition of c_sse2_args moved on the top (L.Landwerlin).
Added mstackrealign for Android's mks where msee4.1 is used.
v4: Added for Vulkan also.
v5: Commit message correction.
CC: <mesa-stable at lists.freedesktop.org>
Fixes: 6b05c080f202 (i965: Compile with -msse3)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit d709f127927cb0ad40d5bf4eaec33c3c27f7738a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ca64c687298af75aba08d2808c70432f8582351
Author: Andres Gomez <agomez at igalia.com>
Date: Fri Sep 7 02:47:23 2018 +0300
cherry-ignore: i965/tools: 32bit compilation with meson
fixes: This commit was immediately reverted by commit 2dce1175c1c.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4c977744ba3f99cd0c71773c684a3247af4ba98a
Author: Andres Gomez <agomez at igalia.com>
Date: Sat Sep 8 01:03:13 2018 +0300
Revert "Revert "glsl: skip stringification in preprocessor if in unreachable branch""
This reverts commit 2fd6f06faabb5b16d529e035ae4523a8566bf9bc.
Take back 28a3731e3f4 ("glsl: skip stringification in preprocessor if in
unreachable branch") after b9fe8ff23dc ("glsl: fixer lexer for
unreachable defines") has made it to the branch.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a471fe120f408bc2e016246e6416b6321739158
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Sat Sep 1 23:57:38 2018 +1000
glsl: fixer lexer for unreachable defines
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define itself is so
this then gets recognised as #if.
Until 28a3731e3f this didn't happen because we ended up in
<HASH>{NONSPACE} where BEGIN INITIAL was called stopping the
problem from happening.
This change makes sure we never call RETURN_TOKEN_NEVER_SKIP for
if/else/endif when processing a define.
Cc: Ian Romanick <idr at freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
Tested-By: Eero Tamminen <eero.t.tamminen at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
(cherry picked from commit b9fe8ff23dcfe4956be1eac4de0838d4a3720315)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ddc689d6815db8d226897b9037378fca753f8aa
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Thu Sep 6 17:43:54 2018 +0300
mesa/util: add missing va_end() after va_copy()
MSDN:
"va_end must be called on each argument list that's initialized
with va_start or va_copy before the function returns."
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810
Fixes: c6267ebd6c8a "gallium/util: Stop bundling our snprintf implementation."
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
(cherry picked from commit 2930b76cfe1e13e84ac0d88f9c6d709a5a8d4c18)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=841dc893ca67fe2d35fb2831d48556beb14ee454
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Thu Sep 6 17:43:53 2018 +0300
mesa/util: don't ignore NULL returned from 'malloc'
We should exit from the function 'util_vasprintf'
with error code -1 for case where 'malloc'
returns NULL
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
(cherry picked from commit 65cfe698b0f4ba412198d212c14481a60c1b8389)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d55da359fa06f5b345273a02a4e6b23f82721bb1
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Thu Sep 6 17:43:52 2018 +0300
mesa/util: don't use the same 'va_list' instance twice
The first usage of the 'va_list' instance could change it.
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
(cherry picked from commit 570cacba7af165175ad40820c5e663db5b1c5066)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e1695569dea2387367e5cd333cf6fc1262e558a7
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Thu Sep 6 17:43:51 2018 +0300
apple/glx/log: added missing va_end() after va_copy()
Each invocation of va_copy() must be matched by a
corresponding invocation of va_end()
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Fixes: 51691f0767f6 "darwin: Use ASL for logging"
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
(cherry picked from commit 267ed29288db478a47d180bd1370a4df60ddb3ef)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=884fa138655ab6d7938e4a5e947a243cc2852a60
Author: Mathias Fröhlich <mathias.froehlich at web.de>
Date: Fri Aug 10 11:37:43 2018 +0200
tnl: Fix green gun regression in xonotic.
Fix an other regression of
mesa: Make gl_vertex_array contain pointers to first order VAO members.
The regression showed up with drivers using the tnl module and
was reproducible using xonotic-glx -benchmark demos/the-big-keybench.dem.
Fixes: 64d2a204805
mesa: Make gl_vertex_array contain pointers to first order VAO members.
Tested-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich at web.de>
(cherry picked from commit a6232b69321b465e9733a4b207088d923b75e714)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=432a95b65f29c068bd33d548f1bef271694e4231
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Tue Sep 4 13:58:01 2018 -0500
anv/pipeline: Only consider double elements which actually exist
The brw_vs_prog_data::double_inputs_read field comes directly from
shader_info::double_inputs which may contain inputs which are not
actually read. Instead of using it directly, AND it with inputs_read
which is only things which are read. Otherwise, we may end up
subtracting too many elements when computing elem_count.
Cc: mesa-stable at lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103241
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 7b26741806c521279a1b83f2eae40a277d806626)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=93726c17c68f64c415962ea1f6234c673d3c1435
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Tue Sep 4 14:42:07 2018 -0700
meson: Print a message about why a libdrm version was selected
We require a single version of libdrm for all of our libdrm
dependencies (core and driver), but the way this is structured can make
the error message less than helpful, as one driver might be the one
setting the libdrm requirement, while another might be the one that
generates the version failure.
This adds a simple message to the output announcing which libdrm module
set the version, which might be more helpful.
v2: - Use message suggested by Eric Engstrom
Fixes: c445b1d56f47922206de55e557444aadb62e11f6
("meson: Use the same version for all libdrm checks")
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
(cherry picked from commit d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb41d6e95c40e024b2dc1339e44a004061606837
Author: Gert Wollny <gert.wollny at collabora.com>
Date: Mon Sep 3 10:05:44 2018 +0200
winsys/virgl: correct resource and handle allocation (v2)
Fixes crash with
piglit/bin/map_buffer_range-invalidate CopyBufferSubData \
increment-offset -auto -fbo
* Resize the resource storage already when the count is equal to the
allocated size, fixes:
Invalid write of size 8
at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629)
by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd
at 0x4C31B25: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567)
* Also resize the space allocated for the handles, fixes:
Invalid write of size 4
at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631)
by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd
at 0x4C2FB0F: malloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so)
by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572)
Fixes: 4b15b5e803e ("virgl: resize resource bo allocation if we need to.")
v2: - Use REALLOC macro and avoid memory leak when re-allocation fails
- add Fixes tag (both Emil Velikov)
- reorder commit message
Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
(cherry picked from commit 9b0e8d87233691c1f025002f1da89ed3f8f69583)
More information about the mesa-commit
mailing list