Mesa (master): llvmpipe: fix undefined shift 1 << 31.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Apr 11 22:54:28 UTC 2019


Module: Mesa
Branch: master
Commit: 604d89c2d10f4d40bbdf06abded60b408547fe9f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=604d89c2d10f4d40bbdf06abded60b408547fe9f

Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Apr 11 20:37:43 2019 +1000

llvmpipe: fix undefined shift 1 << 31.

Pointed out by coverity.

Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>

---

 src/gallium/drivers/llvmpipe/lp_setup_point.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_setup_point.c b/src/gallium/drivers/llvmpipe/lp_setup_point.c
index 2192789bd4c..fc1d5ef6e36 100644
--- a/src/gallium/drivers/llvmpipe/lp_setup_point.c
+++ b/src/gallium/drivers/llvmpipe/lp_setup_point.c
@@ -251,7 +251,7 @@ setup_point_coefficients( struct lp_setup_context *setup,
              * PIPE_MAX_SHADER_OUTPUTS bits.
              */
             if (semantic_index < PIPE_MAX_SHADER_OUTPUTS &&
-                (setup->sprite_coord_enable & (1 << semantic_index))) {
+                (setup->sprite_coord_enable & (1u << semantic_index))) {
                for (i = 0; i < NUM_CHANNELS; i++) {
                   if (usage_mask & (1 << i)) {
                      texcoord_coef(setup, info, slot + 1, i,




More information about the mesa-commit mailing list