Mesa (master): nir/constant_folding: Get rid of a bit size switch statement

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sun Apr 14 20:26:09 UTC 2019


Module: Mesa
Branch: master
Commit: b8197a01a96f5d15268ee5bab28637058f2f962a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8197a01a96f5d15268ee5bab28637058f2f962a

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Mar 27 18:27:39 2019 -0500

nir/constant_folding: Get rid of a bit size switch statement

Now that nir_const_value is a scalar, we don't need the switch on bit
size in order to swizzle them properly.

Reviewed-by: Karol Herbst <kherbst at redhat.com>

---

 src/compiler/nir/nir_opt_constant_folding.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/src/compiler/nir/nir_opt_constant_folding.c b/src/compiler/nir/nir_opt_constant_folding.c
index 60cec7ffda6..84dbce5ac30 100644
--- a/src/compiler/nir/nir_opt_constant_folding.c
+++ b/src/compiler/nir/nir_opt_constant_folding.c
@@ -75,25 +75,7 @@ constant_fold_alu_instr(nir_alu_instr *instr, void *mem_ctx)
 
       for (unsigned j = 0; j < nir_ssa_alu_instr_src_components(instr, i);
            j++) {
-         switch(load_const->def.bit_size) {
-         case 64:
-            src[i][j].u64 = load_const->value[instr->src[i].swizzle[j]].u64;
-            break;
-         case 32:
-            src[i][j].u32 = load_const->value[instr->src[i].swizzle[j]].u32;
-            break;
-         case 16:
-            src[i][j].u16 = load_const->value[instr->src[i].swizzle[j]].u16;
-            break;
-         case 8:
-            src[i][j].u8 = load_const->value[instr->src[i].swizzle[j]].u8;
-            break;
-         case 1:
-            src[i][j].b = load_const->value[instr->src[i].swizzle[j]].b;
-            break;
-         default:
-            unreachable("Invalid bit size");
-         }
+         src[i][j] = load_const->value[instr->src[i].swizzle[j]];
       }
 
       /* We shouldn't have any source modifiers in the optimization loop. */




More information about the mesa-commit mailing list