Mesa (master): winsys/amdgpu: clean up and remove nonsensical assertion
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Apr 23 15:39:08 UTC 2019
Module: Mesa
Branch: master
Commit: 694e320643f7fc6a4f1a9cf3e4ac274c37cccdfb
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=694e320643f7fc6a4f1a9cf3e4ac274c37cccdfb
Author: Marek Olšák <marek.olsak at amd.com>
Date: Thu Feb 14 00:38:37 2019 -0500
winsys/amdgpu: clean up and remove nonsensical assertion
The assertion considers max_dw from the current IB in the chain, but
big_ib_buffer is a buffer for the next IB, which can be smaller.
Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
Acked-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
---
src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
index 83b04ff53af..4a2377f7e09 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
+++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
@@ -1030,8 +1030,7 @@ static bool amdgpu_cs_check_space(struct radeon_cmdbuf *rcs, unsigned dw)
va = amdgpu_winsys_bo(ib->big_ib_buffer)->va;
/* This space was originally reserved. */
- rcs->current.max_dw += 4;
- assert(ib->used_ib_space + 4 * rcs->current.max_dw <= ib->big_ib_buffer->size);
+ rcs->current.max_dw += cs_epilog_dw;
/* Pad with NOPs and add INDIRECT_BUFFER packet */
while ((rcs->current.cdw & 7) != 4)
More information about the mesa-commit
mailing list