Mesa (19.0): 22 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Apr 24 17:39:46 UTC 2019
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c8cdee5dc3c6f9856ee73aed2b47cee77d675022
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Apr 24 10:39:04 2019 -0700
docs: add relnotes for 19.0.3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cb685a3b8c564cdc95e07897c6d59d7f73f2fe0
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Apr 24 10:36:18 2019 -0700
Bump version for 19.0.3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=44ddb884c89366f963d262812f33b6e658c74ea9
Author: Marek Olšák <marek.olsak at amd.com>
Date: Fri Apr 12 11:12:34 2019 -0400
radeonsi: use CP DMA for the null const buffer clear on CIK
This is a workaround for a thread deadlock that I have no idea
why it occurs.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108879
Fixes: 9b331e462e5021d994859756d46cd2519d9c9c6e
Acked-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit b58e5fb6f317be771326f98d498483e45942beaf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba1bf6c3ea54f2ece07770088b026a4322dfccd7
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Apr 23 13:58:45 2019 +0200
radv: do not load vertex attributes that are not provided by the pipeline
Per the Vulkan spec this is definitely invalid but X4 Foundations
does that and it ends up by hanging the GPU.
Found while enabling validation layers with the game. The issue
will be reported to the developers.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 381e38aaaa47c5aa38bc4f504b325fb68b7caea8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f223fb98e9aea2e60f4bfd25bf43c108c9a0d6bc
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Apr 17 14:48:10 2019 -0700
Revert "glsl: Set location on structure-split sampler uniform variables"
This reverts commit 9e0c744f07a21fc7bb018a77cf83b057436d0d1b, which
regressed dEQP-GLES2.functional.uniform_api.random.3. It turns out
that the newly produced location is meaningless and impossible to
consume by drivers that want to look at gl_uniform_storage, so it's
probably better to leave it unset (0) than a number that looks usable.
Leave a tombstone^Wcomment to discourage the next person from making
the obvious looking fix.
See the next commit for a longer description of the problem.
This breaks tests/spec/glsl-1.10/execution/samplers/uniform-struct
on i965, which was originally fixed by the revert. The next commit
will fix it again.
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 47303b466c1b15c9827d935c6c75e89e52b84dde)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=91671ec1f4891eae84c1bd13a77c613962a0cd52
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Mon Mar 11 21:18:48 2019 +0100
gallivm: disable NEON instructions if they are not supported
The LLVM project made some questionable decisions about defaults for
armv7 (e.g. they enable NEON that is not there on NVIDIA and Marvell
platforms).
On top of that, getHostCPUFeatures() doesn't disable missing machine
attributes. Finally, -neon alone is not sufficient to disable emmision
of NEON instructions.
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
(cherry picked from commit e983a975c6843c307380d7caa083eee89e02bd3c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b5090681643d190f14df60bdcdbfe02fa959ea08
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Mon Mar 11 19:16:40 2019 +0100
gallivm: guess CPU features also on ARM
getHostCPUFeatures() is also available on ARM, for even longer time than
for x86. Use it -- it potentially enables instructions that may speed
things up.
Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
Cc: <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/518
Reviewed-by: Matt Turner <mattst88 at gmail.com>
(cherry picked from commit bc6bfc861fd3484c4cc51f24ccb0bf64239fcfd7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2397f5d99dc3f39c83fda1836da160e54366d377
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Apr 16 17:35:05 2019 -0500
anv: Add a #define for the max binding table size
This also fixes a bug where we mis-calculate maximum binding table sizes
and may return true in vkGetDescriptorSetLayoutSupport even for sets too
large to fit in a binding table.
Fixes: ddc40691221 "anv: Implement VK_KHR_maintenance3"
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
(cherry picked from commit a5a0dc08f18928a080e3393ebc694bc7053216fb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ac1ffeab1d5687a3f65112e47010416298e9af9d
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Apr 11 12:20:36 2019 +0100
intel/devinfo: fix missing num_thread_per_eu on ICL
There was an assumption that num_thread_per_eu would be set in the
Gen8 features. Since this is mostly the same of all gen8->11 (except
GEN9_LP that overwrites it) let's just factor it out.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Acked-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Anuj Phogat anuj.phogat at gmail.com
(cherry picked from commit 773e6aa9fd250479e2a89b376e5eda5a1d07fc5b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=229c4abde39f8481d09492eea5b9b4fe98283d78
Author: Eric Anholt <eric at anholt.net>
Date: Wed Apr 17 10:09:14 2019 -0700
nir: Fix deref offset calculation for structs.
We were calcuating the offset for the field within the struct, and just
dropping it on the floor. Fixes a regression in
KHR-GLES3.shaders.struct.local.nested_struct_array_dynamic_index_fragment
and a few of its friends since the scratch lowering commit.
Fixes: e8e159e9df40 ("nir/deref: Add helpers for getting offsets")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 9ac5ec2f90f8b6b2c0e67039b1ae7590374be872)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b5ea4378c3260ff003532c8138a81a57091bdaa0
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Apr 18 09:17:04 2019 +0200
ac/nir: only use the new raw/struct image atomic intrinsics with LLVM 9+
They are buggy with LLVM 8 because they weren't marked as source
of divergence, see r358579.
Fixes: dd0172e865f ("radv: Use structured intrinsics instead of indexing workaround for GFX9.")"
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 31164cf5f70caa94dba0abb93610a935e17f5af2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=23abb7d3109884fb950ee81c92f9fd62b93ffcc2
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Apr 18 17:39:36 2019 +0100
anv: fix uninitialized pthread cond clock domain
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 843775bab78a6b ("anv: Rework fences")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit dfd79079daf08cba0e1d5defc18dedeffb0c6327)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=32e08b23975b5f0ddcff108f6e3927fa7323131b
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Wed Apr 17 09:38:00 2019 +0000
meson: Add dependency on genxml to anvil genfiles
This fixes a race condition where anv_gen_files are executed before
genxml files, which causes a build failure
v2: add dependency on idep_genxml (Lionel)
Fixes: d1992255bb29054fa51763376d125183a9f602f
("meson: Add build Intel "anv" vulkan driver")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit b74e605cf47fe54c0d2a6df072c1874160cfd9eb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bde36e0736c113fbf4a8f69a64d5f817d6d5b0a8
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Mon Mar 25 14:15:27 2019 +0200
intel/compiler: Do not reswizzle dst if instruction writes to flag register
If we write to the flag register changing the swizzle would change
what channels are written to the flag register.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110201
Fixes: 4cd1a0be
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: <ian.d.romanick at intel.com>
(cherry picked from commit 04508f57d1d36587f3cc048f0f5dae0611f9330c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3400359432361ae13c7d68620544c52a17392926
Author: Chia-I Wu <olvaffe at gmail.com>
Date: Tue Apr 9 20:46:38 2019 +0000
virgl: fix fence fd version check
Fixes: d1a1c21e762 ("virgl: native fence fd support")
Signed-off-by: Chia-I Wu <olvaffe at gmail.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit c45c889f95b07cc95cf5ad6fdefc2fa9bb66b960)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce4b6974cdf9133b9e7017cb4f4a3ce186bae8fb
Author: Roland Scheidegger <sroland at vmware.com>
Date: Mon Apr 15 21:36:32 2019 +0200
gallivm: fix bogus assert in get_indirect_index
0 is a valid value as max index, and the code handles it fine. This isn't
commonly seen, as it will only happen with array declarations of size 1.
Fixes piglit tests/shaders/complex-loop-analysis-bug.shader_test
Fixes: a3c898dc97ec "gallivm: fix improper clamping of vertex index when fetching gs inputs"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110441
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit 88e0bbf24aa82000195d10c7873f881d190b825b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ffd4c744d065d865fd7b9064f972ebad85099da
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Wed Apr 10 01:16:25 2019 +0200
ac: Move has_local_buffers disable to radeonsi.
In radv we had a separate flag to actually use it + an env option
to experimentally use it.
The common code setting has_local_buffers to false of course broke
that experimental option.
Also the "enable on APU" did not make sense for RADV as it is still
disabled by default.
Fixes: b21a4efb553 "radv/winsys: allow local BOs on APUs"
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit af9534b9f3f687f3603e621bf282f4c546240afa)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=77dbb70e5c125752319474161cd490d525b6e9d2
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Apr 12 11:07:53 2019 +0100
nir,ac/nir: fix cube_face_coord
Seems it was missing the "/ ma + 0.5" and the order was swapped.
Fixes: a1a2a8dfda7b9cac7e ('nir: add AMD_gcn_shader extended instructions')
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit 8671cfe2a203f2d5492eb22eeb2694e0e37239d9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=332da02f275752ee523d01256073ee1b7ff15430
Author: Andres Gomez <agomez at igalia.com>
Date: Fri Mar 29 12:38:34 2019 +0200
glsl/linker: location aliasing requires types to have the same width
From the OpenGL 4.60.5 spec, section 4.4.1 Input Layout Qualifiers,
Page 67, (Location aliasing):
" Further, when location aliasing, the aliases sharing the location
must have the same underlying numerical type and bit
width (floating-point or integer, 32-bit versus 64-bit, etc.) and
the same auxiliary storage and interpolation qualification."
Additionally, we have improved the linker error descriptions.
Specifically, when taking structs into account we were producing a
linker error because we assumed that all components in each location
were used and that would cause component aliasing. This is not
accurate of the actual problem. Now, the failure specifies that the
underlying numerical type incompatibility is the cause for the
failure.
Fixes the following piglit test:
tests/spec/arb_enhanced_layouts/linker/component-layout/vs-to-fs-width-mismatch-double-float.shader_test
v2:
- Do not assert if we see invalid numerical types. These come
straight from shader code, so we should produce linker errors if
shaders attempt to do location aliasing on variables that are not
numerical such as records.
- While we are at it, improve error reporting for the case of
numerical type mismatch to include the shader stage.
v3:
- Allow location aliasing of images and samplers. If we get these
it means bindless support is active and they should be handled
as 64-bit integers (Ilia)
- Make sure we produce link errors for any non-numerical type
for which we attempt location aliasing, not just structs.
v4:
- Rebased with minor fixes (Andres).
- Added fixing tag to the commit log (Andres).
v5:
- Remove the helper function and check individually for the
underlying numerical type and bit width (Timothy).
- Implicitly, assume that any non-treated type which is checked for
its underlying numerical type is either integer or
float and has a defined bit width (Timothy).
- Implicitly, assume that structs are the only non-treated
non-numerical type (Timothy).
- Improve the linker error descriptions and commit log (Andres).
Fixes: 13652e7516a ("glsl/linker: Fix type checks for location aliasing")
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Iago Toral Quiroga <itoral at igalia.com>
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 75a3dd97aaeb5fea72ab432c8e9f4bd4e50877ed)
[Andres Gomez: is_record() instead of is_struct() and brought glsl_base_type_get_bit_size]
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e63686268028a72df23555253d5ba99aaea9924
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Apr 11 07:04:58 2019 -0700
glsl: Set location on structure-split sampler uniform variables
gl_nir_lower_samplers_as_deref splits structure uniform variables,
creating new variables for individual fields. As part of that, it
calculates a new location. It then never set this on the new variables.
Thanks to Michael Fiano for finding this bug. Fixes crashes on i965
with Piglit's new tests/spec/glsl-1.10/execution/samplers/uniform-struct
test, which was reduced from the failing case in Michael's app.
Fixes: f003859f97c nir: Make gl_nir_lower_samplers use gl_nir_lower_samplers_as_deref
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit 9e0c744f07a21fc7bb018a77cf83b057436d0d1b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9eaa873cf11ffc592ca1f3345b938fc25e2ab12
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Apr 10 14:47:12 2019 -0500
anv/pipeline: Fix MEDIA_VFE_STATE::PerThreadScratchSpace on gen7
We were always programming it with the Broadwell convention which is too
large by a factor of two on Haswell and just plain wrong on IVB and BYT.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 7eaaff18cb6109dd6c4c58de5a4d3be1362b21ae)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=aacefed5218a55826040027a9b04b84d8843f740
Author: Eric Engestrom <eric.engestrom at intel.com>
Date: Tue Apr 9 09:28:17 2019 +0100
meson: remove meson-created megadrivers symlinks
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110356
Fixes: aa7afe324c2092fb31f9 "meson: strip rpath from megadrivers"
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Tested-by: Mike Lothian <mike at fireburn.co.uk>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit c77acc3ceba711ec3790fb674aeb8c6a25433741)
More information about the mesa-commit
mailing list