Mesa (master): radv: don't copy buffer descriptors list for samplers

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Feb 26 10:20:59 UTC 2019


Module: Mesa
Branch: master
Commit: 4924dfc851e52c383380ae56be4d8606684ead7c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4924dfc851e52c383380ae56be4d8606684ead7c

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon Feb 25 15:28:25 2019 +0100

radv: don't copy buffer descriptors list for samplers

Sampler descriptors don't have a buffer list.

This fixes some crashes with new CTS
dEQP-VK.binding_model.descriptor_copy.*.sampler_*.

Cc: 18.3 19.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_descriptor_set.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
index e6649305961..68171b5d244 100644
--- a/src/amd/vulkan/radv_descriptor_set.c
+++ b/src/amd/vulkan/radv_descriptor_set.c
@@ -969,7 +969,11 @@ void radv_update_descriptor_sets(
 			}
 			src_ptr += src_binding_layout->size / 4;
 			dst_ptr += dst_binding_layout->size / 4;
-			dst_buffer_list[j] = src_buffer_list[j];
+
+			if (src_binding_layout->type != VK_DESCRIPTOR_TYPE_SAMPLER) {
+				/* Sampler descriptors don't have a buffer list. */
+				dst_buffer_list[j] = src_buffer_list[j];
+			}
 		}
 	}
 }




More information about the mesa-commit mailing list