Mesa (staging/19.0): nir: initialize value in copy_prop_vars_block
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Feb 26 19:42:14 UTC 2019
Module: Mesa
Branch: staging/19.0
Commit: 2cb6cdc2aa43b5712ef7f95325c24341e7b7f5f3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2cb6cdc2aa43b5712ef7f95325c24341e7b7f5f3
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Mon Feb 25 11:14:11 2019 +0200
nir: initialize value in copy_prop_vars_block
Fixes following valgrind warning:
==27561== Conditional jump or move depends on uninitialised value(s)
==27561== at 0x667856B: value_set_ssa_components (nir_opt_copy_prop_vars.c:78)
==27561== by 0x667A1C4: copy_prop_vars_block (nir_opt_copy_prop_vars.c:797)
Fixes: 62332d139c8 "nir: Add a local variable-based copy propagation pass"
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
(cherry picked from commit 22267feff1a35c4b6f1f0cb9c8e371727f99b5d6)
---
src/compiler/nir/nir_opt_copy_prop_vars.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_opt_copy_prop_vars.c b/src/compiler/nir/nir_opt_copy_prop_vars.c
index 392fef407cf..a71cce19a80 100644
--- a/src/compiler/nir/nir_opt_copy_prop_vars.c
+++ b/src/compiler/nir/nir_opt_copy_prop_vars.c
@@ -653,7 +653,7 @@ copy_prop_vars_block(struct copy_prop_var_state *state,
struct copy_entry *src_entry =
lookup_entry_for_deref(copies, src, nir_derefs_a_contains_b_bit);
- struct value value;
+ struct value value = {0};
if (try_load_from_entry(state, src_entry, b, intrin, src, &value)) {
if (value.is_ssa) {
/* lookup_load has already ensured that we get a single SSA
More information about the mesa-commit
mailing list