Mesa (master): amd/common: Add some parentheses to silence warning.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jan 7 22:18:36 UTC 2019


Module: Mesa
Branch: master
Commit: be6cee51c06dc72ac159bd75b4201c61952515bd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=be6cee51c06dc72ac159bd75b4201c61952515bd

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sat Jan  5 17:45:01 2019 +0100

amd/common: Add some parentheses to silence warning.

[1/59] Compiling C object 'src/amd/common/src at amd@common@@amd_common at sta/ac_nir_to_llvm.c.o'.
../mesa/src/amd/common/ac_nir_to_llvm.c: In function ‘get_inst_tessfactor_writemask’:
../mesa/src/amd/common/ac_nir_to_llvm.c:4089:32: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses]
   writemask = ((1 << num_comps + 1) - 1) << first_component;
                      ~~~~~~~~~~^~~
../mesa/src/amd/common/ac_nir_to_llvm.c:4091:33: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses]
   writemask = (((1 << num_comps + 1) - 1) << first_component) << 4;

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/common/ac_nir_to_llvm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 8dea35178b..5bf91b5171 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -4095,9 +4095,9 @@ get_inst_tessfactor_writemask(nir_intrinsic_instr *intrin)
 	unsigned num_comps = intrin->dest.ssa.num_components;
 
 	if (location == VARYING_SLOT_TESS_LEVEL_INNER)
-		writemask = ((1 << num_comps + 1) - 1) << first_component;
+		writemask = ((1 << (num_comps + 1)) - 1) << first_component;
 	else if (location == VARYING_SLOT_TESS_LEVEL_OUTER)
-		writemask = (((1 << num_comps + 1) - 1) << first_component) << 4;
+		writemask = (((1 << (num_comps + 1)) - 1) << first_component) << 4;
 
 	return writemask;
 }




More information about the mesa-commit mailing list