Mesa (master): intel/batch-decoder: fix a vb end address calculation

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 25 13:20:56 UTC 2019


Module: Mesa
Branch: master
Commit: 4759bb2fcf47388c9c277e514b789dde3c5e3d16
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4759bb2fcf47388c9c277e514b789dde3c5e3d16

Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date:   Thu Jan 24 12:53:53 2019 +0200

intel/batch-decoder: fix a vb end address calculation

According to the loop implementation (in 'ctx_print_buffer' function),
which advances dword by dword over vertex buffer(vb),
the vb size should be aligned by 4 bytes too.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109449
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

---

 src/intel/common/gen_batch_decoder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c
index 2a9c8579a7..916aa3c089 100644
--- a/src/intel/common/gen_batch_decoder.c
+++ b/src/intel/common/gen_batch_decoder.c
@@ -24,6 +24,7 @@
 #include "common/gen_decoder.h"
 #include "gen_disasm.h"
 #include "util/macros.h"
+#include "main/macros.h" /* Needed for ROUND_DOWN_TO */
 
 #include <string.h>
 
@@ -169,7 +170,8 @@ ctx_print_buffer(struct gen_batch_decode_ctx *ctx,
                  uint32_t pitch,
                  int max_lines)
 {
-   const uint32_t *dw_end = bo.map + MIN2(bo.size, read_length);
+   const uint32_t *dw_end =
+         bo.map + ROUND_DOWN_TO(MIN2(bo.size, read_length), 4);
 
    int column_count = 0, line_count = -1;
    for (const uint32_t *dw = bo.map; dw < dw_end; dw++) {




More information about the mesa-commit mailing list